Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detected_object_validation): add 3d pointcloud based validator #5327

chore: add maintainer

be15671
Select commit
Loading
Failed to load commit list.
Merged

fix(detected_object_validation): add 3d pointcloud based validator #5327

chore: add maintainer
be15671
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 15, 2023 in 1m 26s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication obstacle_pointcloud_based_validator.cpp

✅ Improving Code Health:

  • Complex Method obstacle_pointcloud_based_validator.cpp: ObstaclePointCloudBasedValidator::onObjectsAndObstaclePointCloud

Annotations

Check warning on line 272 in perception/detected_object_validation/src/obstacle_pointcloud_based_validator.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 2 functions with similar structure: Validator2D::validate_object,Validator3D::validate_object. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check notice on line 343 in perception/detected_object_validation/src/obstacle_pointcloud_based_validator.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Complex Method

ObstaclePointCloudBasedValidator::onObjectsAndObstaclePointCloud is no longer above the threshold for cyclomatic complexity