Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracking_object_merger): fix unintended error in radar tracking merger #5328

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Oct 17, 2023

Description

After evaluation in xx1 project in TIER IV, #5269 has several unintended error.

This PR fixes apparent error fixed in xx1 project

Tests performed

Tested in tier4/pilot.auto.xx1 project. : tier4#952

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Oct 17, 2023
@YoshiRi YoshiRi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (738c376) 14.77% compared to head (209bdf7) 14.74%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5328      +/-   ##
==========================================
- Coverage   14.77%   14.74%   -0.03%     
==========================================
  Files        1664     1664              
  Lines      115084   115004      -80     
  Branches    35498    35476      -22     
==========================================
- Hits        17007    16963      -44     
+ Misses      78892    78866      -26     
+ Partials    19185    19175      -10     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.74% <ø> (-0.03%) ⬇️ Carriedforward from 738c376

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ehavior_path_planner/src/utils/avoidance/utils.cpp 11.61% <ø> (+0.06%) ⬆️
...rivable_area_expansion/drivable_area_expansion.cpp 44.82% <ø> (+0.45%) ⬆️
.../imu_corrector/src/gyro_bias_estimation_module.cpp 100.00% <ø> (+10.71%) ⬆️
.../imu_corrector/src/gyro_bias_estimation_module.hpp 0.00% <ø> (ø)
sensing/imu_corrector/src/gyro_bias_estimator.cpp 0.00% <ø> (ø)
...orrector/test/test_gyro_bias_estimation_module.cpp 100.00% <ø> (+22.72%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit d38beae into autowarefoundation:main Oct 17, 2023
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants