-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_run_out): ignore momentary detection caused by false positive #5359
Merged
TomohitoAndo
merged 2 commits into
autowarefoundation:main
from
TomohitoAndo:feat/run-out-ignore-momentary-detection
Oct 24, 2023
Merged
feat(behavior_velocity_run_out): ignore momentary detection caused by false positive #5359
TomohitoAndo
merged 2 commits into
autowarefoundation:main
from
TomohitoAndo:feat/run-out-ignore-momentary-detection
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… false positive Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Oct 20, 2023
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
labels
Oct 20, 2023
4 tasks
takayuki5168
approved these changes
Oct 24, 2023
mkuri
approved these changes
Oct 24, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5359 +/- ##
==========================================
- Coverage 14.84% 14.83% -0.01%
==========================================
Files 1649 1649
Lines 114166 114181 +15
Branches 35323 35323
==========================================
Hits 16943 16943
- Misses 78102 78117 +15
Partials 19121 19121
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 25, 2023
… false positive (autowarefoundation#5359) * feat(behavior_velocity_run_out): ignore momentary detection caused by false positive Signed-off-by: Tomohito Ando <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merged
4 tasks
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 25, 2023
… false positive (autowarefoundation#5359) * feat(behavior_velocity_run_out): ignore momentary detection caused by false positive Signed-off-by: Tomohito Ando <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 31, 2023
#991) feat(behavior_velocity_run_out): ignore momentary detection caused by false positive (autowarefoundation#5359) * feat(behavior_velocity_run_out): ignore momentary detection caused by false positive * style(pre-commit): autofix --------- Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: Tomohito ANDO <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current 'run_out' module occasionally inserts unnecessary stop points due to false positives in perception.
To prevent this, I have added a feature that ignores any detection lasting less than a specified duration.
This feature can be toggled on or off using the
enable
parameter.PR for the launch:
autowarefoundation/autoware_launch#647
Related Jira:
TIER IV INTERNAL
Tests performed
Tested on simple planning simulator.
Before
before.mp4
After
after.mp4
Effects on system behavior
None.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.