Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): subscribe traffic light recognition result #5436

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 28, 2023

Description

🤖 Generated by Copilot at bd40cae

This pull request adds the ability for the behavior_path_planner_node to use traffic signals information from the perception module and the lanelet map. It modifies the header and source files of the node and the data manager, and adds the necessary topic remappings and package dependency.


ℹ️ no behavior change. ℹ️

just subscribing traffic light reconginition results /perception/traffic_light_recognition/traffic_signals for feature (#5395) that will be added to avoidance module.

Please review following PR at first.
autowarefoundation/autoware_launch#662

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Oct 28, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (25e8b3f) 15.07% compared to head (1bf632d) 15.02%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5436      +/-   ##
==========================================
- Coverage   15.07%   15.02%   -0.05%     
==========================================
  Files        1662     1662              
  Lines      115724   116167     +443     
  Branches    35753    36080     +327     
==========================================
+ Hits        17441    17458      +17     
- Misses      78749    79139     +390     
- Partials    19534    19570      +36     
Flag Coverage Δ *Carryforward flag
differential 12.21% <0.00%> (?)
total 15.07% <ø> (ø) Carriedforward from 25e8b3f

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...anner/include/behavior_path_planner/parameters.hpp 57.14% <ø> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 47.05% <0.00%> (-2.95%) ⬇️
...or_path_planner/src/behavior_path_planner_node.cpp 26.90% <0.00%> (-0.50%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota changed the title feat(avoidance): use traffic light signal info feat(behavior_path_planner): subscribe traffic light recognition result Oct 28, 2023
@satoshi-ota satoshi-ota force-pushed the feat/bpp-subscribe-traffic-signal branch from bd40cae to 1bf632d Compare October 28, 2023 08:05
@satoshi-ota satoshi-ota marked this pull request as ready for review October 29, 2023 23:26
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 65f0a71 into autowarefoundation:main Oct 30, 2023
27 of 31 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Nov 1, 2023
…lt (autowarefoundation#5436)

feat(avoidance): use traffic light signal info

Signed-off-by: satoshi-ota <[email protected]>
@satoshi-ota satoshi-ota deleted the feat/bpp-subscribe-traffic-signal branch November 26, 2023 07:04
kyoichi-sugahara added a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 13, 2023
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants