-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): improve force avoidance judge logic in order to suppress unnecessary avoidance path #5441
feat(avoidance): improve force avoidance judge logic in order to suppress unnecessary avoidance path #5441
Conversation
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5441 +/- ##
==========================================
- Coverage 14.73% 14.72% -0.01%
==========================================
Files 1665 1665
Lines 116067 116096 +29
Branches 35925 35942 +17
==========================================
Hits 17097 17097
- Misses 79605 79633 +28
- Partials 19365 19366 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ress unnecessary avoidance path (autowarefoundation#5441) * refactor(avoidance): cleanup force avoidance params Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): improve force avoidance judgement Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Description
🤖 Generated by Copilot at 9f3ac65
This pull request refactors the parameters and code of the avoidance module in the behavior path planner. It introduces a new sub-namespace
avoidance.target_filtering.force_avoidance
for the parameters related to the force avoidance feature for stopped vehicle objects. It also adds new functions and variables to check the intersection and force avoidance status of objects, and simplifies the condition check for vehicle type objects. The changes affect the filesavoidance.param.yaml
,manager.cpp
,utils.cpp
,avoidance_module_data.hpp
,utils.hpp
, andlane_change/manager.cpp
.Please review following PR ar first:
autowarefoundation/autoware_launch#667
The avoidance module has a feature to avoid the objects that are ambiguous as to whether they are parked. If the objects are stopping longer than threhold, the module will generate avoidance path for them.
But this feature sometimes generates unnecessary path. Then, I added following two assumption to target object filtering flow:
After this PR, avoidance module doesn't generate avoidance path for them even if it enables force avoidance.
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.