refactor(radar_object_clustering): move radar object clustering parameter to param file #5451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshiri <[email protected]>
github-actions
bot
added
component:perception
YoshiRi
requested review from
scepter914,
miursh and
yukkysaito
as code owners
YoshiRi
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5451 +/- ##
==========================================
- Coverage 15.32% 14.84% -0.48%
==========================================
Files 1721 1663 -58
Lines 118559 114528 -4031
Branches 37995 35342 -2653
==========================================
- Hits 18169 17006 -1163
+ Misses 79657 78321 -1336
+ Partials 20733 19201 -1532
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…eter to param file (autowarefoundation#5451) * move radar object clustering parameter to param file Signed-off-by: yoshiri <[email protected]> * remove default parameter settings and fix cmakelists --------- Signed-off-by: yoshiri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to handle
radar_object_clusteringnode parameters inautoware_launch.🤖 Generated by Copilot at 4cef2e3
This pull request introduces a new node
radar_object_clusteringthat clusters radar objects for better object recognition. It also updates the launch and parameter files of the detection pipelines to use the new node and its parameter file. The goal is to improve the detection of far dynamic objects by fusing radar data with camera and lidar data.Related links
Merge launcher changes first: autowarefoundation/autoware_launch#672.
Tests performed
Tested in Lsim.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.