-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(detection_by_tracker): add ignore option for each label #5473
fix(detection_by_tracker): add ignore option for each label #5473
Conversation
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the name tracker_ignore_label
. If someone else mentioned about it, please fix that.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5473 +/- ##
==========================================
- Coverage 14.82% 14.82% -0.01%
==========================================
Files 1665 1666 +1
Lines 116233 116245 +12
Branches 36257 36257
==========================================
Hits 17231 17231
- Misses 79513 79525 +12
Partials 19489 19489
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…foundation#5473) * fix(detection_by_tracker): add ignore for each class Signed-off-by: badai-nguyen <[email protected]> * fix: launch Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
…foundation#5473) * fix(detection_by_tracker): add ignore for each class Signed-off-by: badai-nguyen <[email protected]> * fix: launch Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]>
fix(detection_by_tracker): add ignore option for each label (autowarefoundation#5473) * fix(detection_by_tracker): add ignore for each class * fix: launch --------- Signed-off-by: badai-nguyen <[email protected]>
Description
This PR to add ignore option for other labels than UNKNOWN as current. This will allow user to flexibly select which class to be detected by tracker.
This should be merged together with autowarefoundation/autoware_launch#676 which keep setting as currently so the result should be unchange after PR merged.
Related link
TIER IV INTERNAL LINK
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.