Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detection_by_tracker): add ignore option for each label #5473

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Nov 2, 2023

Description

This PR to add ignore option for other labels than UNKNOWN as current. This will allow user to flexibly select which class to be detected by tracker.
This should be merged together with autowarefoundation/autoware_launch#676 which keep setting as currently so the result should be unchange after PR merged.

Related link

TIER IV INTERNAL LINK

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Nov 2, 2023
@badai-nguyen badai-nguyen marked this pull request as ready for review November 4, 2023 23:08
@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 13, 2023
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the name tracker_ignore_label. If someone else mentioned about it, please fix that.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (70e3c79) 14.82% compared to head (892b422) 14.82%.
Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5473      +/-   ##
==========================================
- Coverage   14.82%   14.82%   -0.01%     
==========================================
  Files        1665     1666       +1     
  Lines      116233   116245      +12     
  Branches    36257    36257              
==========================================
  Hits        17231    17231              
- Misses      79513    79525      +12     
  Partials    19489    19489              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.82% <ø> (+<0.01%) ⬆️ Carriedforward from 70e3c79

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...detection_by_tracker/detection_by_tracker_core.hpp 0.00% <ø> (ø)
perception/detection_by_tracker/src/utils.cpp 0.00% <0.00%> (ø)
...ction_by_tracker/src/detection_by_tracker_core.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit b97ff3c into autowarefoundation:main Nov 13, 2023
34 of 37 checks passed
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Nov 21, 2023
…foundation#5473)

* fix(detection_by_tracker): add ignore for each class

Signed-off-by: badai-nguyen <[email protected]>

* fix: launch

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen badai-nguyen deleted the fix/detection_by_tracker_for_each_class branch November 22, 2023 02:27
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…foundation#5473)

* fix(detection_by_tracker): add ignore for each class

Signed-off-by: badai-nguyen <[email protected]>

* fix: launch

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
fix(detection_by_tracker): add ignore option for each label (autowarefoundation#5473)

* fix(detection_by_tracker): add ignore for each class



* fix: launch



---------

Signed-off-by: badai-nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants