-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(goal_planner): separate thread safe data #5493
Conversation
4de6e4d
to
a6369db
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5493 +/- ##
==========================================
- Coverage 15.37% 15.36% -0.01%
==========================================
Files 1697 1697
Lines 117494 117531 +37
Branches 37762 37785 +23
==========================================
Hits 18061 18061
- Misses 78864 78895 +31
- Partials 20569 20575 +6
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
9018b21
to
eaf3ca2
Compare
Signed-off-by: kosuke55 <[email protected]>
eaf3ca2
to
70ac3f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…#5493) * refactor(goal_planner): separate thread safe data Signed-off-by: kosuke55 <[email protected]> * fix style(pre-commit): autofix fix fix --------- Signed-off-by: kosuke55 <[email protected]>
Description
status_
Related links
Tests performed
psim
evaluator_description: refactor/goal_planner_thread_safe_data
2023/11/06 https://evaluation.tier4.jp/evaluation/reports/58df5f0b-2bee-5c37-a6f5-8820f16f3a6c/?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/2f0993e2-7c55-5a1f-93f4-1688a5adee04?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/5beeda59-eb94-5097-a30c-448b1588cdb8?project_id=prd_jt
1666/1667
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.