Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): separate thread safe data #5493

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 6, 2023

Description

  • separate thread safe data from status_
  • move pull over path related function in the module to the struct

Related links

Tests performed

psim

evaluator_description: refactor/goal_planner_thread_safe_data
2023/11/06 https://evaluation.tier4.jp/evaluation/reports/58df5f0b-2bee-5c37-a6f5-8820f16f3a6c/?project_id=prd_jt

https://evaluation.tier4.jp/evaluation/reports/2f0993e2-7c55-5a1f-93f4-1688a5adee04?project_id=prd_jt

https://evaluation.tier4.jp/evaluation/reports/5beeda59-eb94-5097-a30c-448b1588cdb8?project_id=prd_jt
1666/1667

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 6, 2023
@kosuke55 kosuke55 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 6, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 6, 2023
@kosuke55 kosuke55 force-pushed the refactor/goal_planner_thread_safe_data branch 4 times, most recently from 4de6e4d to a6369db Compare November 6, 2023 11:26
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 174 lines in your changes are missing coverage. Please review.

Comparison is base (63c1dd6) 15.37% compared to head (70ac3f5) 15.36%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5493      +/-   ##
==========================================
- Coverage   15.37%   15.36%   -0.01%     
==========================================
  Files        1697     1697              
  Lines      117494   117531      +37     
  Branches    37762    37785      +23     
==========================================
  Hits        18061    18061              
- Misses      78864    78895      +31     
- Partials    20569    20575       +6     
Flag Coverage Δ *Carryforward flag
differential 12.68% <2.79%> (?)
total 15.38% <ø> (+0.01%) ⬆️ Carriedforward from 63c1dd6

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...cene_module/start_planner/start_planner_module.cpp 8.01% <100.00%> (ø)
planning/behavior_path_planner/src/utils/utils.cpp 14.10% <100.00%> (+0.11%) ⬆️
...nner/utils/goal_planner/pull_over_planner_base.hpp 13.79% <0.00%> (-5.26%) ⬇️
.../scene_module/goal_planner/goal_planner_module.hpp 15.27% <5.88%> (-13.03%) ⬇️
.../scene_module/goal_planner/goal_planner_module.cpp 3.90% <0.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the refactor/goal_planner_thread_safe_data branch 4 times, most recently from 9018b21 to eaf3ca2 Compare November 9, 2023 02:55
style(pre-commit): autofix

fix

fix
@kosuke55 kosuke55 force-pushed the refactor/goal_planner_thread_safe_data branch from eaf3ca2 to 70ac3f5 Compare November 9, 2023 05:27
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 merged commit ff255eb into main Nov 10, 2023
24 of 28 checks passed
@kosuke55 kosuke55 deleted the refactor/goal_planner_thread_safe_data branch November 10, 2023 10:20
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…#5493)

* refactor(goal_planner): separate thread safe data

Signed-off-by: kosuke55 <[email protected]>

* fix

style(pre-commit): autofix

fix

fix

---------

Signed-off-by: kosuke55 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants