Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ndt_scan_matcher): replace entrypoint with rclcpp components macro #5544

Closed
wants to merge 1 commit into from

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Nov 9, 2023

Description

replace entrypoint main with one generated from rclcpp components macro

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Nov 9, 2023
@KYabuuchi
Copy link
Contributor

@wep21 Hi! 😃 What is the purpose of this change?
Originally, glog was initialized in main(), so if this is changed to components, glog will not be initialized.

@wep21
Copy link
Contributor Author

wep21 commented Nov 10, 2023

How about loading the ndt scan matcher component with glog component?
It is easier to change executor with component.

@wep21
Copy link
Contributor Author

wep21 commented Nov 10, 2023

  • Loading components may increase boot-up time.
  • Main generated from template cannot initialize glog.
    So, I give up merging this PR
    @KYabuuchi Thank you for your comment.

@wep21 wep21 closed this Nov 10, 2023
@wep21 wep21 deleted the replace-entry-point-ndt branch November 10, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants