-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ndt_scan_matcher): make regularization process thread safe #5550
fix(ndt_scan_matcher): make regularization process thread safe #5550
Conversation
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5550 +/- ##
=======================================
Coverage 15.26% 15.27%
=======================================
Files 1713 1713
Lines 118192 118134 -58
Branches 37797 37764 -33
=======================================
- Hits 18047 18046 -1
+ Misses 79595 79538 -57
Partials 20550 20550
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR 🙏 LGTM except the following minor comment:
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]> Co-authored-by: Yamato Ando <[email protected]>
…arefoundation#5550) * use mutex rather than main_callback_group Signed-off-by: Kento Yabuuchi <[email protected]> * subscribe reg_pose only when regularization is enabled Signed-off-by: Kento Yabuuchi <[email protected]> * add some comments to describe Signed-off-by: Kento Yabuuchi <[email protected]> * use initial_pose_callback_group Signed-off-by: Kento Yabuuchi <[email protected]> * fix typo (pauses->poses) Signed-off-by: Kento Yabuuchi <[email protected]> Co-authored-by: Yamato Ando <[email protected]> --------- Signed-off-by: Kento Yabuuchi <[email protected]> Co-authored-by: Yamato Ando <[email protected]>
Description
regularization_pose_msg_ptr_array_
thread-safe.regularization_pose
when regularization is disabled.The reason I did not include the regularization pose subscriber in the
main_callback_group
is so that the regularization process is not neglected even when sensor_callback becomes heavy. Please check the following links for more details:Tests performed
I checked the below points using logging_simulator.
when
regularization_enabled
inndt_scan_matcher.param.yaml
is false, regularization_pose is not subscribed. Also, localization results are as usual.When
regularization_enabled
is true, the node subscribes to theregularization_pose
. When the logger level is set to DEBUG, the following log is shown on the console.[ndt_scan_matcher-32] [DEBUG 1699834328.395343191] [localization.pose_estimator.ndt_scan_matcher]: Regularization pose is set to NDT
Effects on system behavior
This does not affect.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.