feat(motion_velocity_smoother): add motion_velocity_smoother's virtual wall such as MRM #5555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
github-actions
bot
added
the
component:planning
takayuki5168
requested review from
rej55,
mkuri,
TakaHoribe,
purewater0901,
satoshi-ota,
0x126,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
takayuki5168
added
the
run:build-and-test-differential
Merged
4 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5555 +/- ##
=======================================
Coverage 15.36% 15.36%
=======================================
Files 1697 1697
Lines 117472 117480 +8
Branches 37762 37769 +7
=======================================
+ Hits 18051 18053 +2
- Misses 78872 78873 +1
- Partials 20549 20554 +5
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
changed the title
TomohitoAndo
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
LGTM
NOTE:
This PR adds the marker.
autowarefoundation/autoware_launch#684
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 17, 2023
…l wall such as MRM (autowarefoundation#5555) * feat: add motion_velocity_smoother's virtual wall Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
4 tasks
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 20, 2023
…l wall (#1024) feat(motion_velocity_smoother): add motion_velocity_smoother's virtual wall such as MRM (autowarefoundation#5555) * feat: add motion_velocity_smoother's virtual wall * fix --------- Signed-off-by: Takayuki Murooka <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…l wall such as MRM (autowarefoundation#5555) * feat: add motion_velocity_smoother's virtual wall Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when the mrm_confortable_stop_operator requests the motion_velocity_smoother to stop, no virtual wall appears.
For better visualization, this PR adds the virtual wall by motion_velocity_smoother.
This is the case where the ego would leave the lane soon and MRM occurred by lane departure checker.
Tests performed
psim
Effects on system behavior
Added a motion_velocity_smoother's virtual wall
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.