-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lidar_centerpoint): add training docs #5570
refactor(lidar_centerpoint): add training docs #5570
Conversation
#### Install prerequisites | ||
|
||
**Step 1.** Download and install Miniconda from the [official website](https://mmpretrain.readthedocs.io/en/latest/get_started.html). | ||
|
||
**Step 2.** Create a conda virtual environment and activate it | ||
|
||
```bash | ||
conda create --name train-centerpoint python=3.8 -y | ||
conda activate train-centerpoint | ||
``` | ||
|
||
**Step 3.** Install PyTorch | ||
|
||
Please ensure you have PyTorch installed, and compatible with CUDA 11.6, as it is a requirement for current Autoware. | ||
|
||
```bash | ||
conda install pytorch==1.13.1 torchvision==0.14.1 pytorch-cuda=11.6 -c pytorch -c nvidia | ||
``` | ||
|
||
#### Install mmdetection3d | ||
|
||
**Step 1.** Install MMEngine, MMCV, and MMDetection using MIM | ||
|
||
```bash | ||
pip install -U openmim | ||
mim install mmengine | ||
mim install 'mmcv>=2.0.0rc4' | ||
mim install 'mmdet>=3.0.0rc5, <3.3.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add dockerfile to make this environment in https://github.com/autowarefoundation/mmdetection3d.git?
We can make installation step shorter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shin-kyoto -san, thank you for your advice!
Updated the current docker file with these installation steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaancolak
Thank you so much!! Can you update this document to align with the environment setup procedures using Docker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaancolak could you rebase this to latest main? |
Signed-off-by: Kaan Çolak <[email protected]>
Signed-off-by: Kaan Çolak <[email protected]>
Signed-off-by: Kaan Çolak <[email protected]>
Signed-off-by: Kaan Çolak <[email protected]>
Signed-off-by: Kaan Çolak <[email protected]>
3871481
to
3345fd8
Compare
/review |
PR Review
Code feedback:
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
/improve |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5570 +/- ##
==========================================
- Coverage 15.10% 14.99% -0.12%
==========================================
Files 1922 1933 +11
Lines 134796 133074 -1722
Branches 43473 39720 -3753
==========================================
- Hits 20364 19951 -413
+ Misses 91780 90888 -892
+ Partials 22652 22235 -417
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kaan Çolak <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
It seems that there is an issue with spell check. Could you please resolve it? |
docs(lidar_centerpoint): add thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this doc when I reviewed this PR. It looks good to me
Signed-off-by: Kaan Çolak <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
Signed-off-by: Kaan Çolak <[email protected]>
Description
Add training documentation about training lidar CenterPoint model.
Blocks merging of:
Blocked by:
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.