Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(start_planner): add verbose parameter for debug print #5622

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

The PR should be merged first.

  • Added a new parameter "verbose" to the StartPlannerParameters struct.
  • Updated the start_planner.param.yaml file to include the "verbose" parameter.
  • Added a new method receivedNewRoute() in the StartPlannerModule class to check if a new route has been received.
  • Updated the updateData() method to use the receivedNewRoute() method instead of directly checking if a new route has been received.
  • Renamed the method IsGoalBehindOfEgoInSameRouteSegment() to isGoalBehindOfEgoInSameRouteSegment().
  • Added a new method logPullOutStatus() to log the pull out status.
  • Updated the setDebugData() method to call logPullOutStatus() if the "verbose" parameter is true.

Tests performed

debug information can be shown in the terminal
Screenshot from 2023-11-17 19-00-40

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

- Added a new parameter "verbose" to the StartPlannerParameters struct.
- Updated the start_planner.param.yaml file to include the "verbose" parameter.
- Added a new method receivedNewRoute() in the StartPlannerModule class to check if a new route has been received.
- Updated the updateData() method to use the receivedNewRoute() method instead of directly checking if a new route has been received.
- Renamed the method IsGoalBehindOfEgoInSameRouteSegment() to isGoalBehindOfEgoInSameRouteSegment().
- Added a new method logPullOutStatus() to log the pull out status.
- Updated the setDebugData() method to call logPullOutStatus() if the "verbose" parameter is true.

Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 17, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 20, 2023
@kosuke55
Copy link
Contributor

thansk! cool

(operator()():1330) is little noisy.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 224 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (09fab36) 15.29%.
Report is 28 commits behind head on main.

Files Patch % Lines
.../scene_module/goal_planner/goal_planner_module.cpp 1.73% 112 Missing and 1 partial ⚠️
...cene_module/start_planner/start_planner_module.cpp 7.84% 47 Missing ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% 34 Missing and 2 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 15.78% 15 Missing and 1 partial ⚠️
...e/behavior_path_planner/utils/avoidance/helper.hpp 0.00% 4 Missing ⚠️
...ath_planner/src/scene_module/avoidance/manager.cpp 0.00% 0 Missing and 4 partials ⚠️
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
...planner/src/scene_module/start_planner/manager.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5622      +/-   ##
==========================================
- Coverage   15.32%   15.29%   -0.03%     
==========================================
  Files        1721     1721              
  Lines      118559   119456     +897     
  Branches    37995    38717     +722     
==========================================
+ Hits        18169    18275     +106     
- Misses      79657    80347     +690     
- Partials    20733    20834     +101     
Flag Coverage Δ *Carryforward flag
differential 12.63% <4.68%> (?)
total 15.35% <40.00%> (+0.02%) ⬆️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara
Copy link
Contributor Author

@kosuke55
Thank you so much for adding tag and approve.
About (operator()():1330) , this is added because of my bashrc config I belive

@kyoichi-sugahara kyoichi-sugahara merged commit 7fe0b59 into autowarefoundation:main Nov 20, 2023
28 of 32 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/start_planner_debug_print branch November 20, 2023 08:20
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…arefoundation#5622)

* refactor(start_planner): add verbose parameter for debug print

- Added a new parameter "verbose" to the StartPlannerParameters struct.
- Updated the start_planner.param.yaml file to include the "verbose" parameter.
- Added a new method receivedNewRoute() in the StartPlannerModule class to check if a new route has been received.
- Updated the updateData() method to use the receivedNewRoute() method instead of directly checking if a new route has been received.
- Renamed the method IsGoalBehindOfEgoInSameRouteSegment() to isGoalBehindOfEgoInSameRouteSegment().
- Added a new method logPullOutStatus() to log the pull out status.
- Updated the setDebugData() method to call logPullOutStatus() if the "verbose" parameter is true.

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants