refactor(updated-map-based-prediction): rework parameters #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santosh-interplai
requested review from
ktro2828,
kyoichi-sugahara,
miursh,
takayuki5168,
tkimura4,
YoshiRi and
purewater0901
as code owners
github-actions
bot
added
the
component:perception
santosh-interplai
changed the title
Signed-off-by: santosh-interplai <[email protected]>
santosh-sanku
force-pushed
the
update-map-based-prediction
branch
from
5bdf99e to
a10f307
Compare
kminoda
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5656 +/- ##
==========================================
- Coverage 15.32% 0.00% -15.33%
==========================================
Files 1721 5 -1716
Lines 118559 1066 -117493
Branches 37995 0 -37995
==========================================
- Hits 18169 0 -18169
+ Misses 79657 1066 -78591
+ Partials 20733 0 -20733
☔ View full report in Codecov by Sentry. |
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…undation#5656) updated-schema-file Signed-off-by: santosh-interplai <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…undation#5656) updated-schema-file Signed-off-by: santosh-interplai <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…undation#5656) updated-schema-file Signed-off-by: santosh-interplai <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…undation#5656) updated-schema-file Signed-off-by: santosh-interplai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the localization_error_monitor package.
Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
Create the schema
Tests performed
Not applicable.
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.