Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_based_prediction): consider only routable neighbours for lane change #5669

Conversation

mehmetdogru
Copy link
Contributor

@mehmetdogru mehmetdogru commented Nov 24, 2023

Description

closes #5668

Must be merged after autowarefoundation/autoware_launch#703

Tests performed

PR

Effects on system behavior

NONE

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mehmetdogru mehmetdogru self-assigned this Nov 24, 2023
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 24, 2023
@mehmetdogru mehmetdogru added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (c90ab01) 0.00%.
Report is 56 commits behind head on main.

Files Patch % Lines
...based_prediction/src/map_based_prediction_node.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5669       +/-   ##
==========================================
- Coverage   15.32%   0.00%   -15.33%     
==========================================
  Files        1721       5     -1716     
  Lines      118559    1066   -117493     
  Branches    37995       0    -37995     
==========================================
- Hits        18169       0    -18169     
+ Misses      79657    1066    -78591     
+ Partials    20733       0    -20733     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Also, I merged autoware_launch PR. Thank you for your work.

@shmpwk shmpwk merged commit dd8d8a0 into autowarefoundation:main Nov 25, 2023
31 of 37 checks passed
@mehmetdogru mehmetdogru deleted the map_based_prediction/consider-only-routable-neighbours-for-lane-change branch November 28, 2023 01:27
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPC vehicle's predicted path is unfeasible wrt HD-Map
3 participants