refactor(sensing-imu-corrector): rework parameters #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karishma1911
requested review from
kminoda,
TaikiYamada4 and
YamatoAndo
as code owners
github-actions
bot
added
the
component:sensing
karishma1911
force-pushed
the
sensing-imu-corrector
branch
from
42c65e3 to
d7a3a0f
Compare
kminoda
reviewed
Dec 5, 2023
karishma1911
force-pushed
the
sensing-imu-corrector
branch
from
ffd2e2b to
962d3a8
Compare
|
Would you fill the following parts in description other than "not applicable."?
|
okay,sure. |
Signed-off-by: karishma <[email protected]>
Signed-off-by: karishma <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911
force-pushed
the
sensing-imu-corrector
branch
from
f50cc61 to
ca68346
Compare
kminoda
approved these changes
Dec 6, 2023
YamatoAndo
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5780 +/- ##
=======================================
Coverage 15.29% 15.29%
=======================================
Files 1748 1748
Lines 120331 120331
Branches 36695 36695
=======================================
Hits 18404 18404
Misses 81278 81278
Partials 20649 20649
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
karishma1911
added a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…n#5780) * sensing-imu-corrector Signed-off-by: karishma <[email protected]> * sensing-imu-corrector Signed-off-by: karishma <[email protected]> * sensing-imu-corrector Signed-off-by: karishma <[email protected]> --------- Signed-off-by: karishma <[email protected]> Co-authored-by: KK <[email protected]>
karishma1911
added a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…n#5780) * sensing-imu-corrector Signed-off-by: karishma <[email protected]> * sensing-imu-corrector Signed-off-by: karishma <[email protected]> * sensing-imu-corrector Signed-off-by: karishma <[email protected]> --------- Signed-off-by: karishma <[email protected]> Co-authored-by: KK <[email protected]>
karishma1911
added a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…n#5780) * sensing-imu-corrector Signed-off-by: karishma <[email protected]> * sensing-imu-corrector Signed-off-by: karishma <[email protected]> * sensing-imu-corrector Signed-off-by: karishma <[email protected]> --------- Signed-off-by: karishma <[email protected]> Co-authored-by: KK <[email protected]>
karishma1911
added a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…n#5780) * sensing-imu-corrector Signed-off-by: karishma <[email protected]> * sensing-imu-corrector Signed-off-by: karishma <[email protected]> * sensing-imu-corrector Signed-off-by: karishma <[email protected]> --------- Signed-off-by: karishma <[email protected]> Co-authored-by: KK <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the sensing_imu_corrector
Tests performed
No Tests performed
Effects on system behavior
More reliable and faster parameter configuration file creation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.