Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): reset previous modified goal #5785

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 5, 2023

Description

reset previous modified goal when new rouet is received.

if the modified goal for the new route is the same as previous one, the modified goal is not published in
https://github.com/autowarefoundation/autoware.universe/blob/feat/mrm-pull-over-manager/planning/behavior_path_planner/src/behavior_path_planner_node.cpp#L571-L575

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 5, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1279 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (36abfc7) 10.24%.
Report is 159 commits behind head on main.

Files Patch % Lines
...anner/src/utils/avoidance/shift_line_generator.cpp 13.19% 435 Missing and 65 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.58% 168 Missing and 2 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 10.48% 111 Missing and 17 partials ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 1.92% 97 Missing and 5 partials ⚠️
...cene_module/start_planner/start_planner_module.cpp 23.52% 68 Missing and 10 partials ⚠️
..._path_planner/src/marker_utils/avoidance/debug.cpp 0.00% 61 Missing ⚠️
...ath_planner/src/scene_module/avoidance/manager.cpp 18.86% 0 Missing and 43 partials ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp 0.00% 28 Missing ⚠️
..._planner/src/scene_module/goal_planner/manager.cpp 11.53% 2 Missing and 21 partials ⚠️
...planner/src/scene_module/start_planner/manager.cpp 11.53% 6 Missing and 17 partials ⚠️
... and 19 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5785       +/-   ##
===========================================
- Coverage   15.32%   10.24%    -5.09%     
===========================================
  Files        1721       80     -1641     
  Lines      118559    11100   -107459     
  Branches    37995     6209    -31786     
===========================================
- Hits        18169     1137    -17032     
+ Misses      79657     7804    -71853     
+ Partials    20733     2159    -18574     
Flag Coverage Δ
differential 10.24% <13.93%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 74b0a1b into main Dec 5, 2023
@kosuke55 kosuke55 deleted the fix/prev_modified_goal branch December 5, 2023 14:49
@kosuke55 kosuke55 changed the title fix(behavior_path_planner): reset previou modified goal fix(behavior_path_planner): reset previous modified goal Dec 5, 2023
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Dec 8, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants