-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): allow reroute when always executable module running or candidate modules is running #5786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule running or candidate modules Signed-off-by: kosuke55 <[email protected]>
kosuke55
requested review from
rej55,
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
December 5, 2023 14:44
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Dec 5, 2023
kosuke55
changed the title
feat(behavior_path_planner): allow reroute when always executable module running or candidate modules ## Description
feat(behavior_path_planner): allow reroute when always executable module running or candidate modules
Dec 5, 2023
kosuke55
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 5, 2023
takayuki5168
approved these changes
Dec 5, 2023
kosuke55
changed the title
feat(behavior_path_planner): allow reroute when always executable module running or candidate modules
feat(behavior_path_planner): allow reroute when always executable module running or candidate modules is running
Dec 5, 2023
TetsuKawa
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 8, 2023
…ule running or candidate modules is running (autowarefoundation#5786) feat(behavior_path_planner): allow reroute when always executable module running or candidate modules Signed-off-by: kosuke55 <[email protected]>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…ule running or candidate modules is running (autowarefoundation#5786) feat(behavior_path_planner): allow reroute when always executable module running or candidate modules Signed-off-by: kosuke55 <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…ule running or candidate modules is running (autowarefoundation#5786) feat(behavior_path_planner): allow reroute when always executable module running or candidate modules Signed-off-by: kosuke55 <[email protected]> Signed-off-by: karishma <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…ule running or candidate modules is running (autowarefoundation#5786) feat(behavior_path_planner): allow reroute when always executable module running or candidate modules Signed-off-by: kosuke55 <[email protected]> Signed-off-by: karishma <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…ule running or candidate modules is running (autowarefoundation#5786) feat(behavior_path_planner): allow reroute when always executable module running or candidate modules Signed-off-by: kosuke55 <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ule running or candidate modules is running (autowarefoundation#5786) feat(behavior_path_planner): allow reroute when always executable module running or candidate modules Signed-off-by: kosuke55 <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ule running or candidate modules is running (autowarefoundation#5786) feat(behavior_path_planner): allow reroute when always executable module running or candidate modules Signed-off-by: kosuke55 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when only always executable modules (like fixed_goal_planner, dynamic avoidance(in the future?)) are running, reroute is allowd.
Tests performed
psim
https://evaluation.tier4.jp/evaluation/reports/5c739408-fb86-5a94-93ef-b6d9ee3c30ad?project_id=prd_jt
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.