Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): allow reroute when always executable module running or candidate modules is running #5786

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 5, 2023

Description

when only always executable modules (like fixed_goal_planner, dynamic avoidance(in the future?)) are running, reroute is allowd.

Tests performed

psim

https://evaluation.tier4.jp/evaluation/reports/5c739408-fb86-5a94-93ef-b6d9ee3c30ad?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ule running or candidate modules

Signed-off-by: kosuke55 <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 5, 2023
@kosuke55 kosuke55 changed the title feat(behavior_path_planner): allow reroute when always executable module running or candidate modules ## Description feat(behavior_path_planner): allow reroute when always executable module running or candidate modules Dec 5, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 5, 2023
@kosuke55 kosuke55 assigned mkuri and takayuki5168 and unassigned mkuri Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1281 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (0f5945d) 10.23%.
Report is 162 commits behind head on main.

Files Patch % Lines
...anner/src/utils/avoidance/shift_line_generator.cpp 13.19% 435 Missing and 65 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.58% 168 Missing and 2 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 10.48% 111 Missing and 17 partials ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 1.92% 97 Missing and 5 partials ⚠️
...cene_module/start_planner/start_planner_module.cpp 23.52% 68 Missing and 10 partials ⚠️
..._path_planner/src/marker_utils/avoidance/debug.cpp 0.00% 61 Missing ⚠️
...ath_planner/src/scene_module/avoidance/manager.cpp 18.86% 0 Missing and 43 partials ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp 0.00% 28 Missing ⚠️
..._planner/src/scene_module/goal_planner/manager.cpp 11.53% 2 Missing and 21 partials ⚠️
...planner/src/scene_module/start_planner/manager.cpp 11.53% 6 Missing and 17 partials ⚠️
... and 20 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5786       +/-   ##
===========================================
- Coverage   15.32%   10.23%    -5.09%     
===========================================
  Files        1721       80     -1641     
  Lines      118559    11098   -107461     
  Branches    37995     6208    -31787     
===========================================
- Hits        18169     1136    -17033     
+ Misses      79657     7803    -71854     
+ Partials    20733     2159    -18574     
Flag Coverage Δ
differential 10.23% <14.02%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 changed the title feat(behavior_path_planner): allow reroute when always executable module running or candidate modules feat(behavior_path_planner): allow reroute when always executable module running or candidate modules is running Dec 5, 2023
@kosuke55 kosuke55 merged commit b1680c5 into main Dec 5, 2023
40 of 43 checks passed
@kosuke55 kosuke55 deleted the feat/allow_always_exe_reroute branch December 5, 2023 17:25
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Dec 8, 2023
…ule running or candidate modules is running (autowarefoundation#5786)

feat(behavior_path_planner): allow reroute when always executable module running or candidate modules

Signed-off-by: kosuke55 <[email protected]>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…ule running or candidate modules is running (autowarefoundation#5786)

feat(behavior_path_planner): allow reroute when always executable module running or candidate modules

Signed-off-by: kosuke55 <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…ule running or candidate modules is running (autowarefoundation#5786)

feat(behavior_path_planner): allow reroute when always executable module running or candidate modules

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…ule running or candidate modules is running (autowarefoundation#5786)

feat(behavior_path_planner): allow reroute when always executable module running or candidate modules

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…ule running or candidate modules is running (autowarefoundation#5786)

feat(behavior_path_planner): allow reroute when always executable module running or candidate modules

Signed-off-by: kosuke55 <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…ule running or candidate modules is running (autowarefoundation#5786)

feat(behavior_path_planner): allow reroute when always executable module running or candidate modules

Signed-off-by: kosuke55 <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…ule running or candidate modules is running (autowarefoundation#5786)

feat(behavior_path_planner): allow reroute when always executable module running or candidate modules

Signed-off-by: kosuke55 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants