feat!: remove planning factor type #5793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <[email protected]>
github-actions
bot
added
component:planning
isamu-takagi
changed the title
isamu-takagi
requested review from
tkhmy,
yabuta,
mitsudome-r,
yukkysaito,
rej55,
kosuke55,
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4 and
h-ohta
as code owners
Merged
4 tasks
h-ohta
approved these changes
Dec 28, 2023
isamu-takagi
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5793 +/- ##
=======================================
Coverage 15.23% 15.24%
=======================================
Files 1750 1750
Lines 120693 120636 -57
Branches 36739 36694 -45
=======================================
Hits 18392 18392
+ Misses 81674 81619 -55
+ Partials 20627 20625 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
remove planning factor type Signed-off-by: Takagi, Isamu <[email protected]> Co-authored-by: Hiroki OTA <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
remove planning factor type Signed-off-by: Takagi, Isamu <[email protected]> Co-authored-by: Hiroki OTA <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
remove planning factor type Signed-off-by: Takagi, Isamu <[email protected]> Co-authored-by: Hiroki OTA <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
remove planning factor type Signed-off-by: Takagi, Isamu <[email protected]> Co-authored-by: Hiroki OTA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
typefield as it is no longer needed. Please use thebehaviorinstead.Remove the
SteeringFactor::TRYINGbecause it's not actually used.Related: autowarefoundation/autoware_adapi_msgs#48
Tests performed
Please merge autowarefoundation/autoware_adapi_msgs#48 and check if the build is successful.
(Since it is no longer in use, there is no effect on behavior.)
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.