Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(perception-traffic-light-classifier): rework parameters #5797

Closed

Conversation

karishma1911
Copy link
Contributor

@karishma1911 karishma1911 commented Dec 6, 2023

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the traffic-light-classifier

  1. Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.

2.create schema

Tests performed

Not applicable.

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 6, 2023
@karishma1911 karishma1911 force-pushed the traffic-light-classifier branch from 4d8fd78 to 8f6a83d Compare December 6, 2023 12:16
Copy link

stale bot commented Mar 19, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 19, 2024
@xmfcx xmfcx closed this Apr 19, 2024
@xmfcx xmfcx reopened this Apr 19, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Apr 19, 2024
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 19, 2024
@idorobotics
Copy link

@miursh @yukkysaito please urgently review.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late.
LGTM

@idorobotics
Copy link

@karishma1911 could you rebase this to the latest main? To fix the CI.

@karishma1911 karishma1911 requested a review from tzhong518 as a code owner June 3, 2024 04:47
maxime-clem and others added 16 commits June 3, 2024 10:23
…cloud_fusion (autowarefoundation#6840)

* fix(image_projection_based_fusion): add intensity field for roi_pointcloud_fusion

Signed-off-by: badai-nguyen <[email protected]>

* fix: revesve the cluster refinement

Signed-off-by: badai-nguyen <[email protected]>

* fix: typo

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
…loader (autowarefoundation#6872)

Revert "feat(global_parameter_loader): add gtest to global parameter loader (…"

This reverts commit dfec62a.
…ng flip (autowarefoundation#6881)

* feat(perception_online_evaluator): imporve yaw rate metrics considering flip

Signed-off-by: kosuke55 <[email protected]>

* fix test

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
…warefoundation#6398)

* feat(freespace_planning_algorithms): add Astar search by python

Signed-off-by: Takumi Ito <[email protected]>

* add copywrite and remove unneeded comment

Signed-off-by: Takumi Ito <[email protected]>

* - Add method getWaypoints() into the astar class.
- No need to convert to serial when user passes ros2 message to methods.

Signed-off-by: Takumi Ito <[email protected]>

* insert astar python documents into the README

Signed-off-by: Takumi Ito <[email protected]>

* trivial modification

Signed-off-by: Takumi Ito <[email protected]>

* modify typo

Signed-off-by: Takumi Ito <[email protected]>

* Update planning/freespace_planning_algorithms/scripts/bind/astar_search_pybind.cpp

Co-authored-by: Kosuke Takeuchi <[email protected]>

* ad copyright

Signed-off-by: Takumi Ito <[email protected]>

fix copyright

Signed-off-by: Takumi Ito <[email protected]>

add copyright

Signed-off-by: Takumi Ito <[email protected]>

* Update planning/freespace_planning_algorithms/scripts/bind/astar_search_pybind.cpp

---------

Signed-off-by: Takumi Ito <[email protected]>
Co-authored-by: Takumi Ito <[email protected]>
Co-authored-by: Kosuke Takeuchi <[email protected]>
…ne (autowarefoundation#6879)

style(pre-commit): autofix

refactor: topic name

Signed-off-by: Mehmet Emin BAŞOĞLU <[email protected]>
…utowarefoundation#6875)

* enable aeb, fix topic problem

Signed-off-by: Daniel Sanchez <[email protected]>

* eliminate unused var

Signed-off-by: Daniel Sanchez <[email protected]>

* enable aeb, fix topic problem

Signed-off-by: Daniel Sanchez <[email protected]>

* eliminate unused var

Signed-off-by: Daniel Sanchez <[email protected]>

* add clustering method to eliminate small objects/noise

Signed-off-by: Daniel Sanchez <[email protected]>

* remove comments

Signed-off-by: Daniel Sanchez <[email protected]>

* Crop points outside of EGO predicted path

Signed-off-by: Daniel Sanchez <[email protected]>

* remove offset

Signed-off-by: Daniel Sanchez <[email protected]>

* Update library use

Signed-off-by: Daniel Sanchez <[email protected]>

* add check for empty cloud

Signed-off-by: Daniel Sanchez <[email protected]>

* add extra width for pointcloud cropping

Signed-off-by: Daniel Sanchez <[email protected]>

* Use single PC ptr

Signed-off-by: Daniel Sanchez <[email protected]>

* remove problematic option

Signed-off-by: Daniel Sanchez <[email protected]>

* Revert "Use single PC ptr"

This reverts commit b5091fc.

Signed-off-by: Daniel Sanchez <[email protected]>

* refactoring

Signed-off-by: Daniel Sanchez <[email protected]>

* Add back timestamp

Signed-off-by: Daniel Sanchez <[email protected]>

* consider all points in clusters

Signed-off-by: Daniel Sanchez <[email protected]>

* USe object hull to detect collisions

Signed-off-by: Daniel Sanchez <[email protected]>

* Use only closest object point

Signed-off-by: Daniel Sanchez <[email protected]>

* remove unused functions

Signed-off-by: Daniel Sanchez <[email protected]>

* remove debug timer out of code

Signed-off-by: Daniel Sanchez <[email protected]>

* make it so the clustering uses parameters

Signed-off-by: Daniel Sanchez <[email protected]>

* solve type problem

Signed-off-by: Daniel Sanchez <[email protected]>

* update comment

Signed-off-by: Daniel Sanchez <[email protected]>

* update README

Signed-off-by: Daniel Sanchez <[email protected]>

* eliminate member var in favor of local pointcloud ptr

Signed-off-by: Daniel Sanchez <[email protected]>

* remove unused chrono dependency

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
* fix(route_handler): add logger

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix indent

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…tion#6743)

* add param and schema file

Signed-off-by: oguzkaganozt <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: oguzkaganozt <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
* feat(ndt_scan_matcher): remake diag

Signed-off-by: yamato-ando <Yamato ANDO>

* style(pre-commit): autofix

* add latest_ndt_aling_service_best_score

Signed-off-by: yamato-ando <Yamato ANDO>

* style(pre-commit): autofix

* check nullptr

Signed-off-by: yamato-ando <Yamato ANDO>

* style(pre-commit): autofix

* add validate_distance_from_initial_to_result

Signed-off-by: yamato-ando <Yamato ANDO>

* style(pre-commit): autofix

* rename

Signed-off-by: yamato-ando <Yamato ANDO>

* style(pre-commit): autofix

* style(pre-commit): autofix

* [WIP] update

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* [WIP] update

Signed-off-by: Yamato Ando <[email protected]>

* [WIP] update

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* [WIP] update

Signed-off-by: Yamato Ando <[email protected]>

* fix typo

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* [WIP] update

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* update readme

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* [WIP] update

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* [WIP] update

Signed-off-by: Yamato Ando <[email protected]>

* fix typo

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* [WIP] update

Signed-off-by: Yamato Ando <[email protected]>

* [WIP] udpate

Signed-off-by: Yamato Ando <[email protected]>

* [WIP] udpate

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* add is_need_rebuild

Signed-off-by: Yamato Ando <[email protected]>

* fix typo

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* add image

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* remove unused func

Signed-off-by: Yamato Ando <[email protected]>

* fix

Signed-off-by: Yamato Ando <[email protected]>

* fix typo

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* update image

Signed-off-by: Yamato Ando <[email protected]>

* fix typo

Signed-off-by: Yamato Ando <[email protected]>

* fix

Signed-off-by: Yamato Ando <[email protected]>

* remove unused include

Signed-off-by: Yamato Ando <[email protected]>

* move code

Signed-off-by: Yamato Ando <[email protected]>

* move code

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* fix FIX ME

Signed-off-by: Yamato Ando <[email protected]>

* update

Signed-off-by: Yamato Ando <[email protected]>

* remove unused func

Signed-off-by: Yamato Ando <[email protected]>

* [WIP] update

Signed-off-by: Yamato Ando <[email protected]>

* add diag for trigger node service

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* move code

Signed-off-by: Yamato Ando <[email protected]>

* update

Signed-off-by: Yamato Ando <[email protected]>

* delete unused code

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* udpate

Signed-off-by: Yamato Ando <[email protected]>

* delete RCLCPP message

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* update

Signed-off-by: Yamato Ando <[email protected]>

* fix typo

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* rename diag

Signed-off-by: Yamato Ando <[email protected]>

* rename func

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* remove Transition condition to OK

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* fix table

Signed-off-by: Yamato Ando <[email protected]>

* update readme

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* fix order

Signed-off-by: Yamato Ando <[email protected]>

* fix typo

Signed-off-by: Yamato Ando <[email protected]>

* remove diag prefix

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* fix readme

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* rename diag

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* remove unused code

Signed-off-by: Yamato Ando <[email protected]>

* fix double free

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* fix typo

Signed-off-by: Yamato Ando <[email protected]>

* output to terminal

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* fix typo

Signed-off-by: Yamato Ando <[email protected]>

---------

Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: Yamato Ando <[email protected]>
Co-authored-by: yamato-ando <Yamato ANDO>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…els and packages (autowarefoundation#6591)

* refactor: lidar_centerpoint

Signed-off-by: badai-nguyen <[email protected]>

* refactor: pointpainting

Signed-off-by: badai-nguyen <[email protected]>

* chore: fix launch

Signed-off-by: badai-nguyen <[email protected]>

* chore: fix launch

Signed-off-by: badai-nguyen <[email protected]>

* chore: rearrange params

Signed-off-by: badai-nguyen <[email protected]>

* fix: json-schema-check error

Signed-off-by: badai-nguyen <[email protected]>

* fix: default param

Signed-off-by: badai-nguyen <[email protected]>

* refactor: rename param file

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* fix: align centerpoint param namespace with pointpainting

Signed-off-by: badai-nguyen <[email protected]>

* fix(centerpoint): add schema json

Signed-off-by: badai-nguyen <[email protected]>

* fix(pointpainting): fix schema json typo

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

* docs: update pointpainting fusion doc

Signed-off-by: badai-nguyen <[email protected]>

* docs: update lidar centerpoint doc

Signed-off-by: badai-nguyen <[email protected]>

* fix: change omp param

Signed-off-by: badai-nguyen <[email protected]>

* fix:change twist and variance to model params

Signed-off-by: badai-nguyen <[email protected]>

* fix: keep build_only in launch

Signed-off-by: badai-nguyen <[email protected]>

* fix: schema check

Signed-off-by: badai-nguyen <[email protected]>

* chore: temporary remove schema required

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-maumau and others added 24 commits June 3, 2024 10:23
…arefoundation#7187)

* remove unusing main func

Signed-off-by: a-maumau <[email protected]>

* mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* change exec name and change log output from log to both

Signed-off-by: a-maumau <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…warefoundation#7183)

* mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* change log output from screen to both

Signed-off-by: a-maumau <[email protected]>

* style(pre-commit): autofix

* Update localization/pose_estimator_arbiter/CMakeLists.txt

add namespace

Co-authored-by: Kento Yabuuchi <[email protected]>

* remove unusing main func

Signed-off-by: a-maumau <[email protected]>

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kento Yabuuchi <[email protected]>
…tion#7192)

* rename file name and mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* mod to componentize and use glog

Signed-off-by: a-maumau <[email protected]>

* change exec name and add log output both

Signed-off-by: a-maumau <[email protected]>

---------

Signed-off-by: a-maumau <[email protected]>
…refoundation#7181)

* refactor(start_planner): clarify condition of transition to success

Signed-off-by: kyoichi-sugahara <[email protected]>

* modify flowchart

Signed-off-by: kyoichi-sugahara <[email protected]>

* add debug print

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
* change diag time_stamp

Signed-off-by: Yamato Ando <[email protected]>

* fix time now

Signed-off-by: Yamato Ando <[email protected]>

* style(pre-commit): autofix

* rename variable

Signed-off-by: Yamato Ando <[email protected]>

---------

Signed-off-by: Yamato Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… departure check (autowarefoundation#7193)

* add param for lane departure margin

Signed-off-by: Daniel Sanchez <[email protected]>

* json thing

Signed-off-by: Daniel Sanchez <[email protected]>

* docs

Signed-off-by: Daniel Sanchez <[email protected]>

* make separate param for lane departure margin expansion

Signed-off-by: Daniel Sanchez <[email protected]>

* update docs

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
…ion#7208)

* fix(yabloc): fix bug in capturing in lambda function

Signed-off-by: Ryuta Kambe <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…utowarefoundation#7096)

* add geometry utility test code

* style(pre-commit): autofix

* fix scope and declare

* change declare name

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…tprint (autowarefoundation#7186)

feat: filter unknown objects with its footprint

Signed-off-by: yoshiri <[email protected]>
* feat!: remove autoware_auto_geometry package

Signed-off-by: Ryohsuke Mitsudome <[email protected]>

* docs: remove autoware_auto_geometry package from docs

Signed-off-by: Ryohsuke Mitsudome <[email protected]>

---------

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
…re_perception_rviz_plugin (autowarefoundation#7221)

feat(autoware_auto_perception_rviz_plugin): rename package to autoware_perception_rviz_plugin

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (3d849e9) to head (19d04f5).
Report is 125 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5797       +/-   ##
==========================================
- Coverage   15.09%   0.00%   -15.10%     
==========================================
  Files        1967       3     -1964     
  Lines      135941     258   -135683     
  Branches    42122       0    -42122     
==========================================
- Hits        20520       0    -20520     
+ Misses      92700     258    -92442     
+ Partials    22721       0    -22721     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karishma1911
Copy link
Contributor Author

@karishma1911 could you rebase this to the latest main? To fix the CI.

Done!

@idorobotics
Copy link

@karishma1911 DCO checks are failing. Please rebase to main.

@xmfcx
Copy link
Contributor

xmfcx commented Jun 17, 2024

@mitsudome-r
Copy link
Member

@karishma1911 Could you make the change as @xmfcx requested?
There is something wrong with the commit log, and I would like to clean them up before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.