fix(landmark_based_localizer): fix to for moving the definition code of landmarks

[SakodaShintaro]

Description

Since the landmark definition is being moved to autoware_common, this pull request is a corresponding change.

autowarefoundation/autoware_common#219

Tests performed

It has been confirmed that the logging_simulator runs with the same accuracy as before on AWSIM data with GT.

Effects on system behavior

There are no effects on system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[KYabuuchi]

I think this PR is basically OK. 👌 But, I will wait until the PR to autoware_common is reviewed before approving this.

[SakodaShintaro]

@KYabuuchi
autowarefoundation/autoware_common#219 has been merged.
I modified only the URL of the link and ran logging_simulator again to confirm that the code in this PR works with normal accuracy.
Could you please give me a review or approve?

[KYabuuchi]

@SakodaShintaro 🙆‍♂️

[codecov]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (bf55986) 15.24% compared to head (79c7a1e) 15.24%.
Report is 3 commits behind head on main.

Files	Patch %	Lines
...tag_based_localizer/src/ar_tag_based_localizer.cpp	0.00%	6 Missing ⚠️
...ocalizer/landmark_manager/src/landmark_manager.cpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5803   +/-   ##
=======================================
  Coverage   15.24%   15.24%           
=======================================
  Files        1750     1750           
  Lines      120650   120634   -16     
  Branches    36738    36723   -15     
=======================================
  Hits        18392    18392           
+ Misses      81631    81614   -17     
- Partials    20627    20628    +1     

Flag	Coverage Δ		*Carryforward flag
differential	5.79% <0.00%> (?)
total	15.24% <ø> (+<0.01%)	⬆️	Carriedforward from bf55986

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.