-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support of overwriting signals if harsh backlight is detected #5852
feat: add support of overwriting signals if harsh backlight is detected #5852
Conversation
1ce08c0
to
f9a976e
Compare
What camera did you use? |
@yukkysaito Leopard Imaging LI-IMX490 was used in this rosbag |
f9a976e
to
a7f9cf2
Compare
Understood. While this feature seems promising, I'll note an alternative approach here:
Since the parameters here may change depending on the camera, the thresholds should be very generous. |
@yukkysaito Yes, the points you mentioned are reasonable, and there is a movement aiming to improve with the way like these in our team.
I agree with you. In terms of this PR, I think current default threshold is higher enough as far as I experimented. |
perception/traffic_light_classifier/launch/traffic_light_classifier.launch.xml
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5852 +/- ##
==========================================
- Coverage 15.29% 15.26% -0.03%
==========================================
Files 1750 1753 +3
Lines 120566 120741 +175
Branches 36783 36783
==========================================
Hits 18435 18435
- Misses 81465 81640 +175
Partials 20666 20666
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: ktro2828 <[email protected]>
…able node Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
…nkonwn Signed-off-by: ktro2828 <[email protected]>
51639ec
to
e6cb61b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ed (autowarefoundation#5852) * feat: add support of overwriting signals if backlit is detected Signed-off-by: ktro2828 <[email protected]> * feat: remove default parameter in nodelet and update lauch for composable node Signed-off-by: ktro2828 <[email protected]> * docs: update README Signed-off-by: ktro2828 <[email protected]> * docs: update README Signed-off-by: ktro2828 <[email protected]> * feat: update confidence to 0.0 corresponding signals overwritten by unkonwn Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
…ed (autowarefoundation#5852) * feat: add support of overwriting signals if backlit is detected Signed-off-by: ktro2828 <[email protected]> * feat: remove default parameter in nodelet and update lauch for composable node Signed-off-by: ktro2828 <[email protected]> * docs: update README Signed-off-by: ktro2828 <[email protected]> * docs: update README Signed-off-by: ktro2828 <[email protected]> * feat: update confidence to 0.0 corresponding signals overwritten by unkonwn Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
…ed (autowarefoundation#5852) * feat: add support of overwriting signals if backlit is detected Signed-off-by: ktro2828 <[email protected]> * feat: remove default parameter in nodelet and update lauch for composable node Signed-off-by: ktro2828 <[email protected]> * docs: update README Signed-off-by: ktro2828 <[email protected]> * docs: update README Signed-off-by: ktro2828 <[email protected]> * feat: update confidence to 0.0 corresponding signals overwritten by unkonwn Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
…ed (autowarefoundation#5852) * feat: add support of overwriting signals if backlit is detected Signed-off-by: ktro2828 <[email protected]> * feat: remove default parameter in nodelet and update lauch for composable node Signed-off-by: ktro2828 <[email protected]> * docs: update README Signed-off-by: ktro2828 <[email protected]> * docs: update README Signed-off-by: ktro2828 <[email protected]> * feat: update confidence to 0.0 corresponding signals overwritten by unkonwn Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
…ed (autowarefoundation#5852) * feat: add support of overwriting signals if backlit is detected Signed-off-by: ktro2828 <[email protected]> * feat: remove default parameter in nodelet and update lauch for composable node Signed-off-by: ktro2828 <[email protected]> * docs: update README Signed-off-by: ktro2828 <[email protected]> * docs: update README Signed-off-by: ktro2828 <[email protected]> * feat: update confidence to 0.0 corresponding signals overwritten by unkonwn Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
Description
In the case of backlight, current traffic light classifier outputs incorrect color signals as video below.
original.mp4
In this PR, I added support of overwriting signals with unknown if the backlight is detected.
Check each RoI image whether backlight is and overwrite the signal with unknown corresponding to the RoI image.
According to my analysis, in the case of harsh backlight, the intensity values become higher. (RED: mean, CYAN: stddev)
Related links
TIER IV INTERNAL LINK
Tests performed
The result of
backlight_threshold=0.85(default)
in[0.0, 1.0]
.output.mp4
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.