-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ar_tag_based_localizer): refactor pub/sub and so on #5854
refactor(ar_tag_based_localizer): refactor pub/sub and so on #5854
Conversation
Signed-off-by: Shintaro SAKODA <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5854 +/- ##
=======================================
Coverage 15.31% 15.31%
=======================================
Files 1740 1740
Lines 119879 119859 -20
Branches 36450 36444 -6
=======================================
- Hits 18355 18353 -2
+ Misses 80992 80978 -14
+ Partials 20532 20528 -4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a trivial point 🙏
Now this package does not depend on image_transport, so you can remove <depend>image_transport</depend>
from package.xml.
No other problems. 🙆♂️
Signed-off-by: Shintaro SAKODA <[email protected]>
@KYabuuchi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙆♂️
…efoundation#5854) * Fixed ar_tag_based_localizer pub/sub Signed-off-by: Shintaro SAKODA <[email protected]> * Remove dependency on image_transport Signed-off-by: Shintaro SAKODA <[email protected]> --------- Signed-off-by: Shintaro SAKODA <[email protected]>
…efoundation#5854) * Fixed ar_tag_based_localizer pub/sub Signed-off-by: Shintaro SAKODA <[email protected]> * Remove dependency on image_transport Signed-off-by: Shintaro SAKODA <[email protected]> --------- Signed-off-by: Shintaro SAKODA <[email protected]> Signed-off-by: karishma <[email protected]>
…efoundation#5854) * Fixed ar_tag_based_localizer pub/sub Signed-off-by: Shintaro SAKODA <[email protected]> * Remove dependency on image_transport Signed-off-by: Shintaro SAKODA <[email protected]> --------- Signed-off-by: Shintaro SAKODA <[email protected]> Signed-off-by: karishma <[email protected]>
…efoundation#5854) * Fixed ar_tag_based_localizer pub/sub Signed-off-by: Shintaro SAKODA <[email protected]> * Remove dependency on image_transport Signed-off-by: Shintaro SAKODA <[email protected]> --------- Signed-off-by: Shintaro SAKODA <[email protected]>
…efoundation#5854) * Fixed ar_tag_based_localizer pub/sub Signed-off-by: Shintaro SAKODA <[email protected]> * Remove dependency on image_transport Signed-off-by: Shintaro SAKODA <[email protected]> --------- Signed-off-by: Shintaro SAKODA <[email protected]>
…efoundation#5854) * Fixed ar_tag_based_localizer pub/sub Signed-off-by: Shintaro SAKODA <[email protected]> * Remove dependency on image_transport Signed-off-by: Shintaro SAKODA <[email protected]> --------- Signed-off-by: Shintaro SAKODA <[email protected]>
Description
Refactored
ar_tag_based_localizer
./localization/pose_estimator/ar_tag_based_localizer/ar_tag_based_localizer
/localization/pose_estimator/ar_tag_based_localizer
landmark_parser
was running as a node, so it was necessary to create a namespace and launch nodes within it, but that is no longer the case.image_transport
Tests performed
It has been confirmed that the
logging_simulator
runs with the same accuracy as before on AWSIM data with GT.Effects on system behavior
There are no effects on system behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.