Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ar_tag_based_localizer): refactor pub/sub and so on #5854

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Dec 13, 2023

Description

Refactored ar_tag_based_localizer.

  • Changed launch nest
    • Before /localization/pose_estimator/ar_tag_based_localizer/ar_tag_based_localizer
    • After /localization/pose_estimator/ar_tag_based_localizer
    • Previously, landmark_parser was running as a node, so it was necessary to create a namespace and launch nodes within it, but that is no longer the case.
  • Fixed launch.xml to remap correctly
  • Removed image_transport
    • it has allowed to remove setup function also
  • Fixed the code of the qos variable (the contents remain unchanged)
  • Fixed cam_info_callback
  • Fixed test

Tests performed

It has been confirmed that the logging_simulator runs with the same accuracy as before on AWSIM data with GT.

Effects on system behavior

There are no effects on system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 13, 2023
@SakodaShintaro SakodaShintaro self-assigned this Dec 13, 2023
@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (dd3050a) 15.31% compared to head (966e952) 15.31%.
Report is 7 commits behind head on main.

❗ Current head 966e952 differs from pull request most recent head 1a27e43. Consider uploading reports for the commit 1a27e43 to get more accurate results

Files Patch % Lines
...tag_based_localizer/src/ar_tag_based_localizer.cpp 20.00% 9 Missing and 7 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5854   +/-   ##
=======================================
  Coverage   15.31%   15.31%           
=======================================
  Files        1740     1740           
  Lines      119879   119859   -20     
  Branches    36450    36444    -6     
=======================================
- Hits        18355    18353    -2     
+ Misses      80992    80978   -14     
+ Partials    20532    20528    -4     
Flag Coverage Δ *Carryforward flag
differential 8.52% <20.00%> (?)
total 15.31% <ø> (+<0.01%) ⬆️ Carriedforward from dd3050a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro marked this pull request as ready for review December 13, 2023 04:05
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a trivial point 🙏
Now this package does not depend on image_transport, so you can remove <depend>image_transport</depend> from package.xml.

No other problems. 🙆‍♂️

@SakodaShintaro
Copy link
Contributor Author

@KYabuuchi
Thanks. It makes perfect sense.
Fixed in 1a27e43

Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️

@SakodaShintaro SakodaShintaro enabled auto-merge (squash) December 14, 2023 00:07
@SakodaShintaro SakodaShintaro merged commit dff91ba into autowarefoundation:main Dec 14, 2023
18 checks passed
@SakodaShintaro SakodaShintaro deleted the refactor/ar_tag_based_localizer_pub_sub branch December 14, 2023 00:13
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…efoundation#5854)

* Fixed ar_tag_based_localizer pub/sub

Signed-off-by: Shintaro SAKODA <[email protected]>

* Remove dependency on image_transport

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro SAKODA <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…efoundation#5854)

* Fixed ar_tag_based_localizer pub/sub

Signed-off-by: Shintaro SAKODA <[email protected]>

* Remove dependency on image_transport

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro SAKODA <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…efoundation#5854)

* Fixed ar_tag_based_localizer pub/sub

Signed-off-by: Shintaro SAKODA <[email protected]>

* Remove dependency on image_transport

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro SAKODA <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…efoundation#5854)

* Fixed ar_tag_based_localizer pub/sub

Signed-off-by: Shintaro SAKODA <[email protected]>

* Remove dependency on image_transport

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro SAKODA <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…efoundation#5854)

* Fixed ar_tag_based_localizer pub/sub

Signed-off-by: Shintaro SAKODA <[email protected]>

* Remove dependency on image_transport

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro SAKODA <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…efoundation#5854)

* Fixed ar_tag_based_localizer pub/sub

Signed-off-by: Shintaro SAKODA <[email protected]>

* Remove dependency on image_transport

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro SAKODA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants