Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(run_out)!: ignore the collision points on crosswalk #5862

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Dec 13, 2023

Description

New feature to ignore the collision points on crosswalk
image

Screencast.from.2023.12.14.19.34.23.webm

Related links

PR for the launch
autowarefoundation/autoware_launch#737

Tests performed

psim tests was performed

Tier 4 internal test
https://evaluation.tier4.jp/evaluation/reports/a25119ef-0f00-5c86-9c75-374b03e3ef70?project_id=prd_jt

https://evaluation.tier4.jp/evaluation/reports/tables/new?catalog_id=095ae8b3-a23b-4a08-8674-10a681449693&filter=&job_id=db6eadfe-646e-5a43-aa6b-0e5e2540cb66&project_id=prd_jt&table_config=date&target_ids=d75114be-5409-570c-b1c6-ad308c87db33

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 13, 2023
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (0b58725) 15.30% compared to head (14cdb34) 15.30%.
Report is 11 commits behind head on main.

Files Patch % Lines
...ing/behavior_velocity_run_out_module/src/scene.cpp 12.50% 9 Missing and 5 partials ⚠️
...g/behavior_velocity_run_out_module/src/manager.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5862      +/-   ##
==========================================
- Coverage   15.30%   15.30%   -0.01%     
==========================================
  Files        1747     1747              
  Lines      120123   120137      +14     
  Branches    36573    36583      +10     
==========================================
+ Hits        18380    18382       +2     
- Misses      81128    81136       +8     
- Partials    20615    20619       +4     
Flag Coverage Δ *Carryforward flag
differential 18.91% <11.76%> (?)
total 15.30% <ø> (+<0.01%) ⬆️ Carriedforward from 0b58725

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 changed the title suppress on crosswalk feat(run_out)!: ignore the collision points on crosswalk Dec 14, 2023
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review December 14, 2023 10:38
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 force-pushed the feat/run_out/suppress-on-crosswalk branch from 4f0021b to 14cdb34 Compare December 18, 2023 11:05
@yuki-takagi-66 yuki-takagi-66 merged commit e935b3e into autowarefoundation:main Dec 19, 2023
20 of 25 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the feat/run_out/suppress-on-crosswalk branch December 19, 2023 05:19
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…ndation#5862)

* suppress on crosswalk

Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…ndation#5862)

* suppress on crosswalk

Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: karishma <[email protected]>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 11, 2024
…ndation#5862)

* suppress on crosswalk

Signed-off-by: Yuki Takagi <[email protected]>

Signed-off-by: Tomohito Ando <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants