-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(run_out)!: ignore the collision points on crosswalk #5862
Merged
yuki-takagi-66
merged 2 commits into
autowarefoundation:main
from
tier4:feat/run_out/suppress-on-crosswalk
Dec 19, 2023
Merged
feat(run_out)!: ignore the collision points on crosswalk #5862
yuki-takagi-66
merged 2 commits into
autowarefoundation:main
from
tier4:feat/run_out/suppress-on-crosswalk
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Dec 13, 2023
yuki-takagi-66
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 13, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5862 +/- ##
==========================================
- Coverage 15.30% 15.30% -0.01%
==========================================
Files 1747 1747
Lines 120123 120137 +14
Branches 36573 36583 +10
==========================================
+ Hits 18380 18382 +2
- Misses 81128 81136 +8
- Partials 20615 20619 +4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
4 tasks
yuki-takagi-66
changed the title
suppress on crosswalk
feat(run_out)!: ignore the collision points on crosswalk
Dec 14, 2023
yuki-takagi-66
requested review from
mkuri,
shmpwk,
takayuki5168,
TomohitoAndo and
tkimura4
as code owners
December 14, 2023 10:38
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
force-pushed
the
feat/run_out/suppress-on-crosswalk
branch
from
December 18, 2023 11:05
4f0021b
to
14cdb34
Compare
takayuki5168
approved these changes
Dec 18, 2023
yuki-takagi-66
merged commit Dec 19, 2023
e935b3e
into
autowarefoundation:main
20 of 25 checks passed
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…ndation#5862) * suppress on crosswalk Signed-off-by: Yuki Takagi <[email protected]> Signed-off-by: karishma <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…ndation#5862) * suppress on crosswalk Signed-off-by: Yuki Takagi <[email protected]> Signed-off-by: karishma <[email protected]>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 11, 2024
…ndation#5862) * suppress on crosswalk Signed-off-by: Yuki Takagi <[email protected]> Signed-off-by: Tomohito Ando <[email protected]>
Merged
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…ndation#5862) * suppress on crosswalk Signed-off-by: Yuki Takagi <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ndation#5862) * suppress on crosswalk Signed-off-by: Yuki Takagi <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…ndation#5862) * suppress on crosswalk Signed-off-by: Yuki Takagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New feature to ignore the collision points on crosswalk
Screencast.from.2023.12.14.19.34.23.webm
Related links
PR for the launch
autowarefoundation/autoware_launch#737
Tests performed
psim tests was performed
Tier 4 internal test
https://evaluation.tier4.jp/evaluation/reports/a25119ef-0f00-5c86-9c75-374b03e3ef70?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/tables/new?catalog_id=095ae8b3-a23b-4a08-8674-10a681449693&filter=&job_id=db6eadfe-646e-5a43-aa6b-0e5e2540cb66&project_id=prd_jt&table_config=date&target_ids=d75114be-5409-570c-b1c6-ad308c87db33
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.