Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): refine shift pull out path to start pose #5874

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 14, 2023

Description

refine shift pull out path to start pose

Tests performed

before

image

after

image

image

evaluator_description: fix/shift_pull_out_start
2023/12/14 https://evaluation.tier4.jp/evaluation/reports/e8673ccf-7003-5fbb-a379-7c7c6f8cabe8/?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 14, 2023
@kosuke55 kosuke55 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 14, 2023
@kyoichi-sugahara kyoichi-sugahara self-assigned this Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (d4d632a) 15.34% compared to head (76a8501) 15.33%.
Report is 3 commits behind head on main.

Files Patch % Lines
...r_path_start_planner_module/src/shift_pull_out.cpp 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5874      +/-   ##
==========================================
- Coverage   15.34%   15.33%   -0.01%     
==========================================
  Files        1743     1743              
  Lines      119952   119975      +23     
  Branches    36481    36481              
==========================================
  Hits        18402    18402              
- Misses      80963    80986      +23     
  Partials    20587    20587              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.34% <ø> (ø) Carriedforward from 1b72830

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!
Thank you so much!!!!!

Signed-off-by: kosuke55 <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 14, 2023
@kosuke55 kosuke55 merged commit 0dee512 into main Dec 20, 2023
21 of 25 checks passed
@kosuke55 kosuke55 deleted the fix/shift_pull_out_start branch December 20, 2023 05:03
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 20, 2023
…efoundation#5874)

* fix(start_planner): refine shift pull out path to start pose

Signed-off-by: kosuke55 <[email protected]>

* fix typo

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…efoundation#5874)

* fix(start_planner): refine shift pull out path to start pose

Signed-off-by: kosuke55 <[email protected]>

* fix typo

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…efoundation#5874)

* fix(start_planner): refine shift pull out path to start pose

Signed-off-by: kosuke55 <[email protected]>

* fix typo

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…efoundation#5874)

* fix(start_planner): refine shift pull out path to start pose

Signed-off-by: kosuke55 <[email protected]>

* fix typo

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…efoundation#5874)

* fix(start_planner): refine shift pull out path to start pose

Signed-off-by: kosuke55 <[email protected]>

* fix typo

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants