-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner #5875
feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner #5875
Conversation
…r_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <[email protected]>
…ts of interest marker Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: Fumiya Watanabe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Fumiya Watanabe <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5875 +/- ##
=======================================
Coverage 15.34% 15.34%
=======================================
Files 1743 1743
Lines 119950 119963 +13
Branches 36480 36485 +5
=======================================
+ Hits 18401 18408 +7
- Misses 80963 80967 +4
- Partials 20586 20588 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…r_intereface to behavior_velocity_planner (autowarefoundation#5875) * feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <[email protected]> * fix(behavior_velocity_planner_common): add functions to publish objects of interest marker Signed-off-by: Fumiya Watanabe <[email protected]> * feat(no_stopping_area): insert object data Signed-off-by: Fumiya Watanabe <[email protected]> * refactor(behavior_velocity_planner_common): rename function Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
…r_intereface to behavior_velocity_planner (autowarefoundation#5875) * feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <[email protected]> * fix(behavior_velocity_planner_common): add functions to publish objects of interest marker Signed-off-by: Fumiya Watanabe <[email protected]> * feat(no_stopping_area): insert object data Signed-off-by: Fumiya Watanabe <[email protected]> * refactor(behavior_velocity_planner_common): rename function Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]> Signed-off-by: karishma <[email protected]>
…r_intereface to behavior_velocity_planner (autowarefoundation#5875) * feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <[email protected]> * fix(behavior_velocity_planner_common): add functions to publish objects of interest marker Signed-off-by: Fumiya Watanabe <[email protected]> * feat(no_stopping_area): insert object data Signed-off-by: Fumiya Watanabe <[email protected]> * refactor(behavior_velocity_planner_common): rename function Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]> Signed-off-by: karishma <[email protected]>
…r_intereface to behavior_velocity_planner (autowarefoundation#5875) * feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <[email protected]> * fix(behavior_velocity_planner_common): add functions to publish objects of interest marker Signed-off-by: Fumiya Watanabe <[email protected]> * feat(no_stopping_area): insert object data Signed-off-by: Fumiya Watanabe <[email protected]> * refactor(behavior_velocity_planner_common): rename function Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
…r_intereface to behavior_velocity_planner (autowarefoundation#5875) * feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <[email protected]> * fix(behavior_velocity_planner_common): add functions to publish objects of interest marker Signed-off-by: Fumiya Watanabe <[email protected]> * feat(no_stopping_area): insert object data Signed-off-by: Fumiya Watanabe <[email protected]> * refactor(behavior_velocity_planner_common): rename function Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
…r_intereface to behavior_velocity_planner (autowarefoundation#5875) * feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <[email protected]> * fix(behavior_velocity_planner_common): add functions to publish objects of interest marker Signed-off-by: Fumiya Watanabe <[email protected]> * feat(no_stopping_area): insert object data Signed-off-by: Fumiya Watanabe <[email protected]> * refactor(behavior_velocity_planner_common): rename function Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
Description
Apply
objects_of_interest_marker_interface
tobehavior_velocity_planner
.Furthermore, apply to
behavior_velocity_no_stopping_area_module
as example.Related links
#5564
Tests performed
TIER IV INTERNAL TEST
planning simulator
If vehicle is stuck:
If vehicle is not stuck:
Notes for reviewers
Interface changes
See #5564
Effects on system behavior
Objects of interest marker data can be shown.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.