Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): suppress the osqp error about upper/lower bounds #5895

Closed

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 17, 2023

Description

The current Autoware sometimes shows ERROR in osqp_update_lower_bound: upper bound must be greater than or equal to lower bound a lot from the obstacle_avoidance_planner, mainly around reaching the goal.
I checked those values by printing them, but nothing was wrong.

When I added this PR's change, which looks unnecessary though, the error disappeared.

Tests performed

psim

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 17, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review December 17, 2023 15:33
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (90d5b94) 15.30% compared to head (4d3f8ec) 15.30%.
Report is 1 commits behind head on main.

Files Patch % Lines
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5895   +/-   ##
=======================================
  Coverage   15.30%   15.30%           
=======================================
  Files        1747     1747           
  Lines      120119   120122    +3     
  Branches    36570    36571    +1     
=======================================
+ Hits        18380    18383    +3     
  Misses      81124    81124           
  Partials    20615    20615           
Flag Coverage Δ *Carryforward flag
differential 36.48% <60.00%> (?)
total 15.30% <ø> (-0.01%) ⬇️ Carriedforward from 8ff722b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168
Copy link
Contributor Author

#6011 will solve the issue.

@takayuki5168 takayuki5168 deleted the fix/obstacle-avoidance-error branch January 4, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants