Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner_common): remove unused headers #5924

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Dec 20, 2023

Description

Remove unused headers or replace it with more specific ones.
Also add very very very slight clang-tidy refactoring.
I also didn't do it on other modules yet.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 20, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 20, 2023
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@satoshi-ota satoshi-ota enabled auto-merge (squash) December 20, 2023 23:04
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (c9b9fca) 15.29% compared to head (2ea325d) 15.29%.
Report is 16 commits behind head on main.

Files Patch % Lines
...avior_path_planner_common/src/utils/path_utils.cpp 0.00% 5 Missing ⚠️
...s/parking_departure/geometric_parallel_parking.cpp 0.00% 4 Missing ⚠️
...ior_path_planner_common/src/marker_utils/utils.cpp 33.33% 1 Missing and 1 partial ⚠️
.../utils/drivable_area_expansion/path_projection.hpp 66.66% 0 Missing and 1 partial ⚠️
...common/src/interface/steering_factor_interface.cpp 0.00% 1 Missing ⚠️
...or_path_planner_common/src/turn_signal_decider.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5924   +/-   ##
=======================================
  Coverage   15.29%   15.29%           
=======================================
  Files        1748     1749    +1     
  Lines      120279   120350   +71     
  Branches    36673    36656   -17     
=======================================
+ Hits        18399    18410   +11     
- Misses      81247    81330   +83     
+ Partials    20633    20610   -23     
Flag Coverage Δ *Carryforward flag
differential 11.75% <17.64%> (?)
total 15.30% <ø> (+<0.01%) ⬆️ Carriedforward from c9b9fca

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 7eafd60 into autowarefoundation:main Dec 21, 2023
39 of 40 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-behavior-path-common-remove-unused-header branch December 21, 2023 03:41
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants