-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_path_planner_common): remove unused headers #5924
refactor(behavior_path_planner_common): remove unused headers #5924
Conversation
Signed-off-by: Zulfaqar Azmi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5924 +/- ##
=======================================
Coverage 15.29% 15.29%
=======================================
Files 1748 1749 +1
Lines 120279 120350 +71
Branches 36673 36656 -17
=======================================
+ Hits 18399 18410 +11
- Misses 81247 81330 +83
+ Partials 20633 20610 -23
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…refoundation#5924) Signed-off-by: Zulfaqar Azmi <[email protected]>
…refoundation#5924) Signed-off-by: Zulfaqar Azmi <[email protected]>
…refoundation#5924) Signed-off-by: Zulfaqar Azmi <[email protected]>
…refoundation#5924) Signed-off-by: Zulfaqar Azmi <[email protected]>
…refoundation#5924) Signed-off-by: Zulfaqar Azmi <[email protected]>
Description
Remove unused headers or replace it with more specific ones.
Also add very very very slight clang-tidy refactoring.
I also didn't do it on other modules yet.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.