-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): don't ignore objects on straight lane in intersection #5939
Merged
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
satoshi-ota:fix/filter-intersection
Dec 26, 2023
Merged
fix(avoidance): don't ignore objects on straight lane in intersection #5939
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
satoshi-ota:fix/filter-intersection
Dec 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Dec 22, 2023
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
fix/filter-intersection
branch
from
December 23, 2023 07:06
18d81e1
to
b44bb1c
Compare
satoshi-ota
changed the title
fix(safety_check): don't overwrite polygon
fix(avoidance): don't ignore objects on straight lane in intersection
Dec 23, 2023
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
fix/filter-intersection
branch
from
December 24, 2023 08:08
efd16be
to
f095899
Compare
satoshi-ota
requested review from
rej55,
kyoichi-sugahara,
shmpwk,
TakaHoribe,
TomohitoAndo and
tkimura4
as code owners
December 24, 2023 09:47
satoshi-ota
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 26, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5939 +/- ##
==========================================
- Coverage 15.28% 15.27% -0.01%
==========================================
Files 1750 1750
Lines 120432 120465 +33
Branches 36729 36761 +32
==========================================
+ Hits 18404 18406 +2
- Misses 81375 81382 +7
- Partials 20653 20677 +24
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rej55
approved these changes
Dec 26, 2023
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 8, 2024
…autowarefoundation#5939) * fix(avoidance): don't ignore objects on straight lane in intersection Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix filtering flow Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 1, 2024
…autowarefoundation#5939) * fix(avoidance): don't ignore objects on straight lane in intersection Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix filtering flow Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 8, 2024
…autowarefoundation#5939) * fix(avoidance): don't ignore objects on straight lane in intersection Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix filtering flow Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…autowarefoundation#5939) * fix(avoidance): don't ignore objects on straight lane in intersection Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix filtering flow Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…autowarefoundation#5939) * fix(avoidance): don't ignore objects on straight lane in intersection Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix filtering flow Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…autowarefoundation#5939) * fix(avoidance): don't ignore objects on straight lane in intersection Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix filtering flow Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…autowarefoundation#5939) * fix(avoidance): don't ignore objects on straight lane in intersection Signed-off-by: satoshi-ota <[email protected]> * fix(avoidance): fix filtering flow Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basically, it is able to filter objects that should be avoid with high confidence if the ego goes straight in intersection because the lane infomation defined in HDMap is relatively accurate. On the other hand, it is more difficult to filter avoidance target objects based on right/left turning lane since sometimes thier lane bounds are not painted on ground in real world. Additionally, there are vehicles turn left and merge to ego lane, and ego vehicle doesn't have to avoid them.
Then, avoidance module uses some filtering condition (e.g. objects merging to ego lane are ignored.) for objects on right/left lane in order not to output unnecessary avoidance path.
But I found those condition applied for objects on straight lane unintentionally and caused scenario fails as follow.
simplescreenrecorder-2023-12-24_18.04.10.mp4
In this PR, I fixed this issue and confirmed that avoidance module could output path expectedly.
Tests performed
simplescreenrecorder-2023-12-24_17.56.10.mp4
Effects on system behavior
Improve avoidance module behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.