fix(avoidance): fix condition to trim front shift line

[satoshi-ota]

Description

Avoidance module keeps distance between ego and shift line start point farther than threshold. And it trims shift lines whose start point is closer than threshold as invalid path. But both of threshold (shift line generation and validation) refer common value (calculate in helper_->getMinimumPrepareDistance()).Then, sometimes front shift line is trimmed unexpectedly.

As a result, invalid output path is generated. In this PR, I fixed validate function and add 1e-3 to check condition.

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[shmpwk]

LGTM

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2e2f184) 15.28% compared to head (2830d2f) 15.27%.
Report is 8 commits behind head on main.

Files	Patch %	Lines
...path_avoidance_module/src/shift_line_generator.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5949      +/-   ##
==========================================
- Coverage   15.28%   15.27%   -0.01%     
==========================================
  Files        1750     1750              
  Lines      120432   120465      +33     
  Branches    36729    36761      +32     
==========================================
+ Hits        18404    18406       +2     
- Misses      81375    81382       +7     
- Partials    20653    20677      +24     

Flag	Coverage Δ		*Carryforward flag
differential	13.22% <0.00%> (?)
total	15.28% <ø> (+<0.01%)	⬆️	Carriedforward from 2e2f184

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.