Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bpp): remove virtual qualifier #5968

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 26, 2023

Description

Hide updateCurrentState() as private function. Inherit class only can override state transit conditions, and interface decides next state based on them.

This PR contains following modifications.

  • remove virtual qualifier from updateState()
  • remove virtual qualifier from updateCurrentState()
  • move current_state_ to private

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 26, 2023
@satoshi-ota satoshi-ota force-pushed the refactor/behavior-path-interface branch from 6519ae7 to eaa686b Compare December 26, 2023 10:02
@satoshi-ota satoshi-ota changed the title refactor(bpp): remove depricated variable and functions from behavior path module interface refactor(bpp): remove virtual qualifier Dec 26, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review December 26, 2023 10:12
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) December 26, 2023 10:24
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 26, 2023
@satoshi-ota satoshi-ota disabled auto-merge December 26, 2023 10:29
Signed-off-by: satoshi-ota <[email protected]>
@satoshi-ota satoshi-ota enabled auto-merge (squash) December 26, 2023 10:38
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 172 lines in your changes are missing coverage. Please review.

Comparison is base (1d6e7e8) 15.28% compared to head (828141d) 15.28%.
Report is 7 commits behind head on main.

Files Patch % Lines
...nning/behavior_path_avoidance_module/src/utils.cpp 0.00% 82 Missing ⚠️
...behavior_path_lane_change_module/src/interface.cpp 0.00% 70 Missing and 1 partial ⚠️
...ing/behavior_path_lane_change_module/src/scene.cpp 0.00% 7 Missing ⚠️
...nning/behavior_path_avoidance_module/src/scene.cpp 0.00% 6 Missing ⚠️
...path_avoidance_by_lane_change_module/src/scene.cpp 0.00% 4 Missing ⚠️
...ude/behavior_path_lane_change_module/interface.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5968      +/-   ##
==========================================
- Coverage   15.28%   15.28%   -0.01%     
==========================================
  Files        1750     1750              
  Lines      120568   120599      +31     
  Branches    36781    36776       -5     
==========================================
  Hits        18434    18434              
- Misses      81469    81499      +30     
- Partials    20665    20666       +1     
Flag Coverage Δ *Carryforward flag
differential 11.78% <0.00%> (?)
total 15.30% <ø> (+0.01%) ⬆️ Carriedforward from 1d6e7e8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit e877070 into autowarefoundation:main Dec 26, 2023
21 of 24 checks passed
@satoshi-ota satoshi-ota deleted the refactor/behavior-path-interface branch December 26, 2023 23:10
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
* refactor(bpp): hide module state as private

Signed-off-by: satoshi-ota <[email protected]>

* fix(bpp): fix logger level

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
* refactor(bpp): hide module state as private

Signed-off-by: satoshi-ota <[email protected]>

* fix(bpp): fix logger level

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
* refactor(bpp): hide module state as private

Signed-off-by: satoshi-ota <[email protected]>

* fix(bpp): fix logger level

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* refactor(bpp): hide module state as private

Signed-off-by: satoshi-ota <[email protected]>

* fix(bpp): fix logger level

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
* refactor(bpp): hide module state as private

Signed-off-by: satoshi-ota <[email protected]>

* fix(bpp): fix logger level

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants