-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(bpp): remove virtual qualifier #5968
refactor(bpp): remove virtual qualifier #5968
Conversation
Signed-off-by: satoshi-ota <[email protected]>
6519ae7
to
eaa686b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: satoshi-ota <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5968 +/- ##
==========================================
- Coverage 15.28% 15.28% -0.01%
==========================================
Files 1750 1750
Lines 120568 120599 +31
Branches 36781 36776 -5
==========================================
Hits 18434 18434
- Misses 81469 81499 +30
- Partials 20665 20666 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* refactor(bpp): hide module state as private Signed-off-by: satoshi-ota <[email protected]> * fix(bpp): fix logger level Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
* refactor(bpp): hide module state as private Signed-off-by: satoshi-ota <[email protected]> * fix(bpp): fix logger level Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
* refactor(bpp): hide module state as private Signed-off-by: satoshi-ota <[email protected]> * fix(bpp): fix logger level Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
* refactor(bpp): hide module state as private Signed-off-by: satoshi-ota <[email protected]> * fix(bpp): fix logger level Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
* refactor(bpp): hide module state as private Signed-off-by: satoshi-ota <[email protected]> * fix(bpp): fix logger level Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Description
Hide
updateCurrentState()
as private function. Inherit class only can override state transit conditions, and interface decides next state based on them.This PR contains following modifications.
virtual
qualifier fromupdateState()
virtual
qualifier fromupdateCurrentState()
current_state_
to privateTests performed
Psim
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.