Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_utils, etc): add header argument in convertToTrajectory #6021

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 6, 2024

Description

Added a header argument with a default value in motion_utils::convertToTrajectory, which is a necessary variable for the visualization in Rviz.
And removed the utility functions to fill in the header of the trajectory which became unnecessary with the upper change in the obstacle_avoidance_planner, path_smoother, path_sampler, and planning_topic_converter packages.

Tests performed

psim

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jan 6, 2024
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 6, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review January 6, 2024 20:06
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5de111f) 15.23% compared to head (de6176f) 15.23%.

Files Patch % Lines
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 0.00% 0 Missing and 3 partials ⚠️
planning/obstacle_avoidance_planner/src/node.cpp 33.33% 1 Missing and 1 partial ⚠️
planning/path_smoother/src/elastic_band.cpp 0.00% 0 Missing and 2 partials ⚠️
...anning/path_smoother/src/elastic_band_smoother.cpp 0.00% 1 Missing and 1 partial ⚠️
...g/sampling_based_planner/path_sampler/src/node.cpp 0.00% 2 Missing ⚠️
planning/obstacle_cruise_planner/src/node.cpp 0.00% 0 Missing and 1 partial ⚠️
...lanning_topic_converter/src/path_to_trajectory.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6021      +/-   ##
==========================================
- Coverage   15.23%   15.23%   -0.01%     
==========================================
  Files        1751     1751              
  Lines      120918   120898      -20     
  Branches    36770    36779       +9     
==========================================
- Hits        18421    18416       -5     
+ Misses      81825    81812      -13     
+ Partials    20672    20670       -2     
Flag Coverage Δ *Carryforward flag
differential 18.31% <7.14%> (?)
total 15.23% <ø> (-0.01%) ⬇️ Carriedforward from 5de111f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit eb09f68 into autowarefoundation:main Jan 7, 2024
39 of 43 checks passed
@takayuki5168 takayuki5168 deleted the feat/convert-to-trajectory-with-header branch January 7, 2024 04:49
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…utowarefoundation#6021)

* feat(motion_utils, etc): add header argument in convertToTrajectory

Signed-off-by: Takayuki Murooka <[email protected]>

* fix include

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…utowarefoundation#6021)

* feat(motion_utils, etc): add header argument in convertToTrajectory

Signed-off-by: Takayuki Murooka <[email protected]>

* fix include

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…utowarefoundation#6021)

* feat(motion_utils, etc): add header argument in convertToTrajectory

Signed-off-by: Takayuki Murooka <[email protected]>

* fix include

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…utowarefoundation#6021)

* feat(motion_utils, etc): add header argument in convertToTrajectory

Signed-off-by: Takayuki Murooka <[email protected]>

* fix include

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant