-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(motion_utils, etc): add header argument in convertToTrajectory #6021
Merged
takayuki5168
merged 2 commits into
autowarefoundation:main
from
tier4:feat/convert-to-trajectory-with-header
Jan 7, 2024
Merged
feat(motion_utils, etc): add header argument in convertToTrajectory #6021
takayuki5168
merged 2 commits into
autowarefoundation:main
from
tier4:feat/convert-to-trajectory-with-header
Jan 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <[email protected]>
github-actions
bot
added
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:common
Common packages from the autoware-common repository. (auto-assigned)
labels
Jan 6, 2024
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 6, 2024
takayuki5168
requested review from
maxime-clem,
kosuke55,
satoshi-ota,
shmpwk,
yuki-takagi-66,
TakaHoribe,
rej55,
soblin,
taikitanaka3 and
tkimura4
as code owners
January 6, 2024 20:06
4 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6021 +/- ##
==========================================
- Coverage 15.23% 15.23% -0.01%
==========================================
Files 1751 1751
Lines 120918 120898 -20
Branches 36770 36779 +9
==========================================
- Hits 18421 18416 -5
+ Misses 81825 81812 -13
+ Partials 20672 20670 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…utowarefoundation#6021) * feat(motion_utils, etc): add header argument in convertToTrajectory Signed-off-by: Takayuki Murooka <[email protected]> * fix include Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…utowarefoundation#6021) * feat(motion_utils, etc): add header argument in convertToTrajectory Signed-off-by: Takayuki Murooka <[email protected]> * fix include Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…utowarefoundation#6021) * feat(motion_utils, etc): add header argument in convertToTrajectory Signed-off-by: Takayuki Murooka <[email protected]> * fix include Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…utowarefoundation#6021) * feat(motion_utils, etc): add header argument in convertToTrajectory Signed-off-by: Takayuki Murooka <[email protected]> * fix include Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a header argument with a default value in motion_utils::convertToTrajectory, which is a necessary variable for the visualization in Rviz.
And removed the utility functions to fill in the header of the trajectory which became unnecessary with the upper change in the obstacle_avoidance_planner, path_smoother, path_sampler, and planning_topic_converter packages.
Tests performed
psim
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.