Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(freespace_planner): only plan if ego is stopped #6062

Conversation

VRichardJP
Copy link
Contributor

Fixes #5936

Description

See #5936 (comment)

Tests performed

Screencast.from.01-12-2024.03_57_19.PM.webm

Effects on system behavior

On a parking, freespace planner will only plan new trajectories if the vehicle is stopped. If a new obstacle is found on the current trajectory, the planner will first modify current trajectory to stop the vehicle, and only create a new trajectory once the vehicle is stopped.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 12, 2024
@VRichardJP VRichardJP force-pushed the freespace_planner_wait_for_stopped branch 3 times, most recently from 0b26fab to d15a97c Compare January 22, 2024 05:22
@VRichardJP VRichardJP force-pushed the freespace_planner_wait_for_stopped branch from d15a97c to 17f5674 Compare January 29, 2024 01:19
…nner_node.cpp


Add const

Co-authored-by: Kosuke Takeuchi <[email protected]>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 14.58%. Comparing base (b307b3d) to head (03c5aca).
Report is 15 commits behind head on main.

❗ Current head 03c5aca differs from pull request most recent head 648fce9. Consider uploading reports for the commit 648fce9 to get more accurate results

Files Patch % Lines
...r/src/freespace_planner/freespace_planner_node.cpp 55.55% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6062      +/-   ##
==========================================
- Coverage   14.96%   14.58%   -0.39%     
==========================================
  Files        1967     1877      -90     
  Lines      135953   127657    -8296     
  Branches    40556    37286    -3270     
==========================================
- Hits        20352    18622    -1730     
+ Misses      92946    88182    -4764     
+ Partials    22655    20853    -1802     
Flag Coverage Δ *Carryforward flag
differential 31.18% <55.55%> (?)
total 14.58% <ø> (-0.39%) ⬇️ Carriedforward from 81790e1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem
Copy link
Contributor

@TakaHoribe, @takayuki5168, can we merge this PR ?

@takayuki5168
Copy link
Contributor

@maxime-clem Takeuchi-kun already approved, so I think it's fine.

@maxime-clem
Copy link
Contributor

My mistake, I thought the PR was waiting for a code owner to approve, but the json-schema-check is what is blocking.
I updated the branch and if the CI passes it should be possible to merge.

Copy link

stale bot commented May 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 8, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 8, 2024
@maxime-clem maxime-clem merged commit 43adbd5 into autowarefoundation:main May 8, 2024
23 of 24 checks passed
@VRichardJP VRichardJP deleted the freespace_planner_wait_for_stopped branch May 8, 2024 19:32
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller outputs way too high velocity/acceleration
4 participants