-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(freespace_planner): only plan if ego is stopped #6062
feat(freespace_planner): only plan if ego is stopped #6062
Conversation
0b26fab
to
d15a97c
Compare
Fixes autowarefoundation#5936 Signed-off-by: Vincent Richard <[email protected]>
d15a97c
to
17f5674
Compare
planning/freespace_planner/src/freespace_planner/freespace_planner_node.cpp
Outdated
Show resolved
Hide resolved
…nner_node.cpp Add const Co-authored-by: Kosuke Takeuchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6062 +/- ##
==========================================
- Coverage 14.96% 14.58% -0.39%
==========================================
Files 1967 1877 -90
Lines 135953 127657 -8296
Branches 40556 37286 -3270
==========================================
- Hits 20352 18622 -1730
+ Misses 92946 88182 -4764
+ Partials 22655 20853 -1802
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@TakaHoribe, @takayuki5168, can we merge this PR ? |
@maxime-clem Takeuchi-kun already approved, so I think it's fine. |
My mistake, I thought the PR was waiting for a code owner to approve, but the |
This pull request has been automatically marked as stale because it has not had recent activity. |
…ion#6062) Signed-off-by: Vincent Richard <[email protected]> Signed-off-by: vividf <[email protected]>
…ion#6062) Signed-off-by: Vincent Richard <[email protected]>
Fixes #5936
Description
See #5936 (comment)
Tests performed
Screencast.from.01-12-2024.03_57_19.PM.webm
Effects on system behavior
On a parking, freespace planner will only plan new trajectories if the vehicle is stopped. If a new obstacle is found on the current trajectory, the planner will first modify current trajectory to stop the vehicle, and only create a new trajectory once the vehicle is stopped.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.