Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radar_tracks_noise_filter): add unit test #6113

Merged

Conversation

N-Eiki
Copy link
Contributor

@N-Eiki N-Eiki commented Jan 18, 2024

Description

Close #5893 and reopen this PR.
Add isNoise filter unit test

Related links

Tests performed

test by colcon test

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Jan 18, 2024
@N-Eiki N-Eiki changed the title feat/test_radar_tracks_noise_filter feat(radar_tracks_noise_filter): add unit test Jan 18, 2024
@scepter914 scepter914 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 19, 2024
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MUST] Please change the file name from test_radar_tracks_noise_filter_isNoise.cpp to test_radar_tracks_noise_filter_is_noise.cpp.

Signed-off-by: N-Eiki <[email protected]>
@N-Eiki N-Eiki requested a review from scepter914 January 25, 2024 10:20
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (f6e4550) 14.58% compared to head (fc21a19) 14.60%.
Report is 5 commits behind head on main.

Files Patch % Lines
...filter/test_radar_tracks_noise_filter_is_noise.cpp 50.00% 4 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6113      +/-   ##
==========================================
+ Coverage   14.58%   14.60%   +0.01%     
==========================================
  Files        1878     1879       +1     
  Lines      128023   128047      +24     
  Branches    37468    37498      +30     
==========================================
+ Hits        18671    18697      +26     
+ Misses      88377    88355      -22     
- Partials    20975    20995      +20     
Flag Coverage Δ *Carryforward flag
differential 41.26% <50.00%> (?)
total 14.58% <ø> (ø) Carriedforward from f6e4550

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scepter914 scepter914 merged commit 4c3ea87 into autowarefoundation:main Jan 29, 2024
22 of 24 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 29, 2024
* feat/test_radar_tracks_noise_filter

Signed-off-by: N-Eiki <[email protected]>

* change file name

Signed-off-by: N-Eiki <[email protected]>

---------

Signed-off-by: N-Eiki <[email protected]>
Co-authored-by: Satoshi Tanaka <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* feat/test_radar_tracks_noise_filter

Signed-off-by: N-Eiki <[email protected]>

* change file name

Signed-off-by: N-Eiki <[email protected]>

---------

Signed-off-by: N-Eiki <[email protected]>
Co-authored-by: Satoshi Tanaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants