-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radar_tracks_noise_filter): add unit test #6113
feat(radar_tracks_noise_filter): add unit test #6113
Conversation
Signed-off-by: N-Eiki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MUST] Please change the file name from test_radar_tracks_noise_filter_isNoise.cpp to test_radar_tracks_noise_filter_is_noise.cpp.
Signed-off-by: N-Eiki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6113 +/- ##
==========================================
+ Coverage 14.58% 14.60% +0.01%
==========================================
Files 1878 1879 +1
Lines 128023 128047 +24
Branches 37468 37498 +30
==========================================
+ Hits 18671 18697 +26
+ Misses 88377 88355 -22
- Partials 20975 20995 +20
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* feat/test_radar_tracks_noise_filter Signed-off-by: N-Eiki <[email protected]> * change file name Signed-off-by: N-Eiki <[email protected]> --------- Signed-off-by: N-Eiki <[email protected]> Co-authored-by: Satoshi Tanaka <[email protected]>
* feat/test_radar_tracks_noise_filter Signed-off-by: N-Eiki <[email protected]> * change file name Signed-off-by: N-Eiki <[email protected]> --------- Signed-off-by: N-Eiki <[email protected]> Co-authored-by: Satoshi Tanaka <[email protected]>
Description
Close #5893 and reopen this PR.
Add isNoise filter unit test
Related links
Tests performed
test by colcon test
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.