Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk): add option to slowdown at occluded crosswalks #6122

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jan 19, 2024

Description

Add a feature to slowdown when passing a crosswalk if it occluded.

Requires the launch PR: autowarefoundation/autoware_launch#807

Tests performed

Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/7e2f793c-c950-5a48-a185-b40f42001ecd?project_id=prd_jt

Effects on system behavior

slowdown when passing an occluded crosswalk.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Summary by CodeRabbit

  • New Feature: Added the ability to slow down when passing an occluded crosswalk. This feature includes new parameters for handling occlusions and a safety slowdown speed. The code initializes these parameters from the ROS parameter server. The CrosswalkModule class now supports slowing down based on occlusions, and a new function applySafetySlowDownSpeed applies a safety slowdown speed to the path. Dependencies grid_map_core, grid_map_ros, grid_map_utils, interpolation, and nav_msgs were added to the package.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jan 19, 2024
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 19, 2024
@maxime-clem maxime-clem force-pushed the feat/crosswalk-occluded_pedestrians branch from 1713f95 to c6cf65b Compare January 19, 2024 13:07
@github-actions github-actions bot removed the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 19, 2024
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 140 lines in your changes are missing coverage. Please review.

Comparison is base (c9e6dda) 14.99% compared to head (f48deca) 14.98%.
Report is 47 commits behind head on main.

Files Patch % Lines
...locity_crosswalk_module/src/occluded_crosswalk.cpp 0.00% 88 Missing ⚠️
...behavior_velocity_crosswalk_module/src/manager.cpp 13.33% 0 Missing and 26 partials ⚠️
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6122      +/-   ##
==========================================
- Coverage   14.99%   14.98%   -0.02%     
==========================================
  Files        1838     1839       +1     
  Lines      127099   127216     +117     
  Branches    38075    38156      +81     
==========================================
+ Hits        19062    19066       +4     
- Misses      86715    86801      +86     
- Partials    21322    21349      +27     
Flag Coverage Δ *Carryforward flag
differential 11.19% <2.77%> (?)
total 15.00% <ø> (+<0.01%) ⬆️ Carriedforward from c9e6dda

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem force-pushed the feat/crosswalk-occluded_pedestrians branch 4 times, most recently from a92322e to 291e1b7 Compare January 24, 2024 00:47
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 24, 2024
@maxime-clem maxime-clem force-pushed the feat/crosswalk-occluded_pedestrians branch from f4c7084 to 789bf72 Compare January 24, 2024 05:45
@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) and removed component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jan 24, 2024
@maxime-clem maxime-clem force-pushed the feat/crosswalk-occluded_pedestrians branch from 3e63967 to 1575217 Compare January 26, 2024 06:31
@github-actions github-actions bot removed the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 26, 2024
@maxime-clem maxime-clem force-pushed the feat/crosswalk-occluded_pedestrians branch from 1575217 to c10a27a Compare January 29, 2024 02:31
@maxime-clem maxime-clem marked this pull request as ready for review January 29, 2024 02:41
@maxime-clem maxime-clem force-pushed the feat/crosswalk-occluded_pedestrians branch from c10a27a to 3a3a484 Compare February 2, 2024 02:49
@maxime-clem maxime-clem removed the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 2, 2024
@maxime-clem maxime-clem force-pushed the feat/crosswalk-occluded_pedestrians branch from aa4cbfa to 31bd431 Compare February 3, 2024 12:54
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
This reverts commit 391c7bd322a4e95953675a629f5c7d42cfd2d98e.

Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
@maxime-clem maxime-clem force-pushed the feat/crosswalk-occluded_pedestrians branch from 7f375ac to e8ef9a2 Compare February 19, 2024 12:03
@maxime-clem maxime-clem force-pushed the feat/crosswalk-occluded_pedestrians branch from e8ef9a2 to f48deca Compare February 19, 2024 12:33
@maxime-clem maxime-clem added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Feb 19, 2024
@maxime-clem
Copy link
Contributor Author

@maxime-clem Do you have a chart to describe this occluded crosswalk?

Sorry I just added the documentation: https://autowarefoundation.github.io/autoware.universe/pr-6122/planning/behavior_velocity_crosswalk_module/#occlusion
Let me know if something is not clear.

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 21, 2024
@maxime-clem maxime-clem merged commit 1b64aa2 into autowarefoundation:main Feb 22, 2024
36 of 42 checks passed
@maxime-clem maxime-clem deleted the feat/crosswalk-occluded_pedestrians branch February 22, 2024 04:31
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants