Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): add deciding status to check collision for for a certain period of time #6128

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 21, 2024

Description

add deciding status to check collision for for a certain period of time

before:
transit DECIDED path status soon if current path has no collision and ego vehicle is close enogh to the pull over start pose.

after:
transit DECIDING path status to check collision for certain period of time. After that transit DECIDED.

Tests performed

psim
evaluator_description: feat/diciding_status_goal_planner
2024/01/22 https://evaluation.tier4.jp/evaluation/reports/152a0e19-00c0-5672-87cc-cb890ec47116/?project_id=prd_jt

evaluator_description: feat/diciding_status_goal_planner
2024/01/22 https://evaluation.tier4.jp/evaluation/reports/227d58ab-1b54-57fd-9ef5-28f1bd937906/?project_id=prd_jt

https://evaluation.tier4.jp/evaluation/reports/b9299466-6c46-5dc8-928e-71eb53b4a9fb?project_id=prd_jt
goal planner scenarios faile only by

Simulator waited for the Autoware state to transition to WaitingForRoute, but time is up. The current Autoware state is INITIALIZING.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 21, 2024
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 21, 2024
@kosuke55 kosuke55 marked this pull request as ready for review January 21, 2024 17:05
@kosuke55 kosuke55 force-pushed the feat/diciding_status_goal_planner branch from d4d1b26 to d66d632 Compare January 21, 2024 17:08
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (3019aab) 14.59% compared to head (e5dc05a) 14.58%.
Report is 3 commits behind head on main.

Files Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 51 Missing ⚠️
...ior_path_goal_planner_module/src/goal_searcher.cpp 0.00% 17 Missing ⚠️
...ing/behavior_path_goal_planner_module/src/util.cpp 0.00% 13 Missing ⚠️
...r_path_goal_planner_module/goal_planner_module.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6128      +/-   ##
==========================================
- Coverage   14.59%   14.58%   -0.01%     
==========================================
  Files        1868     1868              
  Lines      127475   127493      +18     
  Branches    37317    37317              
==========================================
  Hits        18600    18600              
- Misses      87956    87974      +18     
  Partials    20919    20919              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.59% <ø> (+<0.01%) ⬆️ Carriedforward from 3019aab

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the feat/diciding_status_goal_planner branch 3 times, most recently from e3a81ac to 811f556 Compare January 22, 2024 13:15
@kosuke55 kosuke55 force-pushed the feat/diciding_status_goal_planner branch from 811f556 to 093ce0c Compare January 23, 2024 03:32
Signed-off-by: kosuke55 <[email protected]>
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 merged commit 05f8ea3 into main Jan 23, 2024
23 of 27 checks passed
@kosuke55 kosuke55 deleted the feat/diciding_status_goal_planner branch January 23, 2024 05:21
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 23, 2024
…certain period of time (autowarefoundation#6128)

* feat(goal_planner): add deciding status to check collision for for a certain period of time

Signed-off-by: kosuke55 <[email protected]>

* add hysterisys and debug print

Signed-off-by: kosuke55 <[email protected]>

* check goal longitudinal margin when deciding

Signed-off-by: kosuke55 <[email protected]>

* clean up

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 27, 2024
…certain period of time (autowarefoundation#6128)

* feat(goal_planner): add deciding status to check collision for for a certain period of time

Signed-off-by: kosuke55 <[email protected]>

* add hysterisys and debug print

Signed-off-by: kosuke55 <[email protected]>

* check goal longitudinal margin when deciding

Signed-off-by: kosuke55 <[email protected]>

* clean up

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 28, 2024
…certain period of time (autowarefoundation#6128)

* feat(goal_planner): add deciding status to check collision for for a certain period of time

Signed-off-by: kosuke55 <[email protected]>

* add hysterisys and debug print

Signed-off-by: kosuke55 <[email protected]>

* check goal longitudinal margin when deciding

Signed-off-by: kosuke55 <[email protected]>

* clean up

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…certain period of time (autowarefoundation#6128)

* feat(goal_planner): add deciding status to check collision for for a certain period of time

Signed-off-by: kosuke55 <[email protected]>

* add hysterisys and debug print

Signed-off-by: kosuke55 <[email protected]>

* check goal longitudinal margin when deciding

Signed-off-by: kosuke55 <[email protected]>

* clean up

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants