-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(goal_planner): add deciding status to check collision for for a certain period of time #6128
Conversation
d4d1b26
to
d66d632
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6128 +/- ##
==========================================
- Coverage 14.59% 14.58% -0.01%
==========================================
Files 1868 1868
Lines 127475 127493 +18
Branches 37317 37317
==========================================
Hits 18600 18600
- Misses 87956 87974 +18
Partials 20919 20919
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e3a81ac
to
811f556
Compare
…certain period of time Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: kosuke55 <[email protected]>
811f556
to
093ce0c
Compare
Signed-off-by: kosuke55 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…certain period of time (autowarefoundation#6128) * feat(goal_planner): add deciding status to check collision for for a certain period of time Signed-off-by: kosuke55 <[email protected]> * add hysterisys and debug print Signed-off-by: kosuke55 <[email protected]> * check goal longitudinal margin when deciding Signed-off-by: kosuke55 <[email protected]> * clean up Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]>
…certain period of time (autowarefoundation#6128) * feat(goal_planner): add deciding status to check collision for for a certain period of time Signed-off-by: kosuke55 <[email protected]> * add hysterisys and debug print Signed-off-by: kosuke55 <[email protected]> * check goal longitudinal margin when deciding Signed-off-by: kosuke55 <[email protected]> * clean up Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]>
…certain period of time (autowarefoundation#6128) * feat(goal_planner): add deciding status to check collision for for a certain period of time Signed-off-by: kosuke55 <[email protected]> * add hysterisys and debug print Signed-off-by: kosuke55 <[email protected]> * check goal longitudinal margin when deciding Signed-off-by: kosuke55 <[email protected]> * clean up Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]>
…certain period of time (autowarefoundation#6128) * feat(goal_planner): add deciding status to check collision for for a certain period of time Signed-off-by: kosuke55 <[email protected]> * add hysterisys and debug print Signed-off-by: kosuke55 <[email protected]> * check goal longitudinal margin when deciding Signed-off-by: kosuke55 <[email protected]> * clean up Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]>
Description
add deciding status to check collision for for a certain period of time
before:
transit DECIDED path status soon if current path has no collision and ego vehicle is close enogh to the pull over start pose.
after:
transit DECIDING path status to check collision for certain period of time. After that transit DECIDED.
Tests performed
psim
evaluator_description: feat/diciding_status_goal_planner
2024/01/22 https://evaluation.tier4.jp/evaluation/reports/152a0e19-00c0-5672-87cc-cb890ec47116/?project_id=prd_jt
evaluator_description: feat/diciding_status_goal_planner
2024/01/22 https://evaluation.tier4.jp/evaluation/reports/227d58ab-1b54-57fd-9ef5-28f1bd937906/?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/b9299466-6c46-5dc8-928e-71eb53b4a9fb?project_id=prd_jt
goal planner scenarios faile only by
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.