-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(object_velocity_splitter): rework parameters #6158
chore(object_velocity_splitter): rework parameters #6158
Conversation
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6158 +/- ##
==========================================
+ Coverage 14.40% 14.62% +0.22%
==========================================
Files 1906 1868 -38
Lines 129849 126937 -2912
Branches 37572 37044 -528
==========================================
- Hits 18699 18566 -133
+ Misses 90156 87504 -2652
+ Partials 20994 20867 -127
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n#6158) * chore(object_velocity_splitter): add param file Signed-off-by: kminoda <[email protected]> * fix Signed-off-by: kminoda <[email protected]> * fix arg name Signed-off-by: kminoda <[email protected]> * fix: update launch param handling Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]>
Description
Add a parameter file.
Must be merged with autowarefoundation/autoware_launch#820
Tests performed
velocity_threshold
is loaded as 5.5.velocity_threshold
is loaded as 4.5.velocity_threshold
is loaded as 4.5.Effects on system behavior
No effect expected
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.