Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): sort keep last modules considering priority #6174

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 25, 2024

Description

sort keep last modules considering priority.
when the parameter is following dynamic_avoiadnce shoulder be last.

    goal_planner:
      enable_rtc: false
      enable_simultaneous_execution_as_approved_module: true
      enable_simultaneous_execution_as_candidate_module: false
      keep_last: true
      priority: 1
      max_module_size: 1

    dynamic_avoidance:
      enable_rtc: false
      enable_simultaneous_execution_as_approved_module: true
      enable_simultaneous_execution_as_candidate_module: true
      keep_last: true
      priority: 7
      max_module_size: 1

before
image

after
image

Tests performed

psim

2024/01/25 https://evaluation.tier4.jp/evaluation/reports/2744b0ff-2c3b-5816-94fd-0f0ffe27b725/?project_id=prd_jt

https://evaluation.tier4.jp/evaluation/reports/254e158d-7800-583e-b078-7a9529a53b86?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 25, 2024
@kosuke55 kosuke55 marked this pull request as ready for review January 25, 2024 06:43
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (ccd852b) 14.58% compared to head (1a0c61b) 14.58%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ning/behavior_path_planner/src/planner_manager.cpp 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6174      +/-   ##
==========================================
- Coverage   14.58%   14.58%   -0.01%     
==========================================
  Files        1871     1871              
  Lines      127545   127556      +11     
  Branches    37311    37315       +4     
==========================================
  Hits        18606    18606              
- Misses      88019    88030      +11     
  Partials    20920    20920              
Flag Coverage Δ *Carryforward flag
differential 9.45% <0.00%> (?)
total 14.58% <ø> (+<0.01%) ⬆️ Carriedforward from ccd852b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55
Copy link
Contributor Author

seems to need to inherit modified goal

@kosuke55
Copy link
Contributor Author

kosuke55 commented Jan 26, 2024

@kosuke55 kosuke55 merged commit 0a057e1 into autowarefoundation:main Jan 26, 2024
20 of 24 checks passed
@kosuke55 kosuke55 deleted the fix/keep_last branch January 26, 2024 16:59
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 27, 2024
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 28, 2024
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Jan 29, 2024
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 29, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants