-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ekf_localizer): rework parameters #6196
refactor(ekf_localizer): rework parameters #6196
Conversation
99207d8
to
88f4f81
Compare
3ce3148
to
a41202c
Compare
fc30c3e
to
15dacad
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6196 +/- ##
==========================================
- Coverage 14.91% 14.36% -0.55%
==========================================
Files 1817 1907 +90
Lines 125357 130137 +4780
Branches 37640 37641 +1
==========================================
+ Hits 18693 18697 +4
- Misses 85652 90426 +4774
- Partials 21012 21014 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dda33fd
to
7bc163b
Compare
a3be667
to
6dee595
Compare
I will review soon. Please wait 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pose_frame_id
parameter has a default value so please modify it. 🙏
Except for that, there is no problem
localization/ekf_localizer/include/ekf_localizer/hyper_parameters.hpp
Outdated
Show resolved
Hide resolved
347e5fb
to
48109f1
Compare
0c7f674
to
76d11bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙆
f43c38f
to
1602f56
Compare
Signed-off-by: Motsu-san <[email protected]>
Signed-off-by: Motsu-san <[email protected]>
Signed-off-by: Motsu-san <[email protected]>
Signed-off-by: Motsu-san <[email protected]>
with arrangement of param .yaml Signed-off-by: Motsu-san <[email protected]>
1602f56
to
a363f86
Compare
* refactor: Create JSON Schema files Signed-off-by: Motsu-san <[email protected]> * Fix: Modify the descriptions of parameters Signed-off-by: Motsu-san <[email protected]> * fix: Redo modification of the descriptions Signed-off-by: Motsu-san <[email protected]> * doc: Replace parameter tables to JSON Schema ones in README Signed-off-by: Motsu-san <[email protected]> * refactor: Remove default value from source code and launch.xml with arrangement of param .yaml Signed-off-by: Motsu-san <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Motsu-san <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* refactor: Create JSON Schema files Signed-off-by: Motsu-san <[email protected]> * Fix: Modify the descriptions of parameters Signed-off-by: Motsu-san <[email protected]> * fix: Redo modification of the descriptions Signed-off-by: Motsu-san <[email protected]> * doc: Replace parameter tables to JSON Schema ones in README Signed-off-by: Motsu-san <[email protected]> * refactor: Remove default value from source code and launch.xml with arrangement of param .yaml Signed-off-by: Motsu-san <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Motsu-san <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* refactor: Create JSON Schema files Signed-off-by: Motsu-san <[email protected]> * Fix: Modify the descriptions of parameters Signed-off-by: Motsu-san <[email protected]> * fix: Redo modification of the descriptions Signed-off-by: Motsu-san <[email protected]> * doc: Replace parameter tables to JSON Schema ones in README Signed-off-by: Motsu-san <[email protected]> * refactor: Remove default value from source code and launch.xml with arrangement of param .yaml Signed-off-by: Motsu-san <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Motsu-san <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
This pull request must be merged with the autoware_launch pull request.
Please see both pull request.
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371.
Parameters
chapter in the readme file.Tests performed
confirm parameters
expected result
Confirm json schema
result
Confirm README display
mkdocs serve
with this instruction.Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.