chore(traffic_light_map_based_detector): rework parameters #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tzhong518 <[email protected]>
github-actions
bot
added
the
component:perception
Signed-off-by: tzhong518 <[email protected]>
github-actions
bot
added
the
component:launch
kminoda
reviewed
Feb 1, 2024
launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Show resolved
Hide resolved
Signed-off-by: tzhong518 <[email protected]>
Signed-off-by: tzhong518 <[email protected]>
kminoda
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6200 +/- ##
========================================
Coverage 14.38% 14.39%
========================================
Files 1907 1906 -1
Lines 129918 129809 -109
Branches 37617 37527 -90
========================================
- Hits 18695 18686 -9
+ Misses 90213 90162 -51
+ Partials 21010 20961 -49
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: tzhong518 <[email protected]>
miursh
reviewed
Feb 9, 2024
launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Outdated
Show resolved
Hide resolved
kminoda
reviewed
Feb 9, 2024
launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Outdated
Show resolved
Hide resolved
…n/traffic_light.launch.xml
kminoda
reviewed
Feb 9, 2024
launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Outdated
Show resolved
Hide resolved
launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Outdated
Show resolved
Hide resolved
miursh
approved these changes
Feb 9, 2024
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…oundation#6200) * chore: use config Signed-off-by: tzhong518 <[email protected]> * chore: use config Signed-off-by: tzhong518 <[email protected]> * fix: revert min_timestamp_offset Signed-off-by: tzhong518 <[email protected]> * fix: revert min_timestamp_offset Signed-off-by: tzhong518 <[email protected]> * fix: delete param Signed-off-by: tzhong518 <[email protected]> * style(pre-commit): autofix * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml * revert: revert change in min&max timestamp offset Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: tzhong518 <[email protected]> Signed-off-by: kminoda <[email protected]> Co-authored-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…oundation#6200) * chore: use config Signed-off-by: tzhong518 <[email protected]> * chore: use config Signed-off-by: tzhong518 <[email protected]> * fix: revert min_timestamp_offset Signed-off-by: tzhong518 <[email protected]> * fix: revert min_timestamp_offset Signed-off-by: tzhong518 <[email protected]> * fix: delete param Signed-off-by: tzhong518 <[email protected]> * style(pre-commit): autofix * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml * revert: revert change in min&max timestamp offset Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: tzhong518 <[email protected]> Signed-off-by: kminoda <[email protected]> Co-authored-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use param file for traffic_light_map_based_detector
Tests performed
Launch Autoware and confirm that the parameters are loaded successfully.
Effects on system behavior
No effect expected
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.