Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): judge pass judge at intersection without tl with occlusion detection #6207

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 29, 2024

Description

Basically pass judge passage is judged when "was_safe". And when occlusion detection is enabled, at intersection without traffic light, "OccludedAbsenceTrafficLight" context is treated as safe in terms of occlusion.

Related links

https://tier4.atlassian.net/browse/RT1-4771

Tests performed

intersection occlusion is ON

Before this PR

the pass judge line is still green after passage

image

After this PR

the pass judge line turns red after passage

image

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 29, 2024
@soblin soblin force-pushed the feat/intersection/pass-judge-decision-at-intersection-wo-tl-with-occlusion branch from cd7e36c to 5289b18 Compare January 29, 2024 08:38
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 29, 2024
@soblin soblin enabled auto-merge (squash) January 29, 2024 10:52
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (daf0824) 14.58% compared to head (5289b18) 14.57%.
Report is 7 commits behind head on main.

Files Patch % Lines
...ity_intersection_module/src/scene_intersection.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6207      +/-   ##
==========================================
- Coverage   14.58%   14.57%   -0.01%     
==========================================
  Files        1878     1878              
  Lines      128023   128099      +76     
  Branches    37468    37531      +63     
==========================================
  Hits        18673    18673              
- Misses      88376    88449      +73     
- Partials    20974    20977       +3     
Flag Coverage Δ *Carryforward flag
differential 4.69% <0.00%> (?)
total 14.58% <ø> (+<0.01%) ⬆️ Carriedforward from daf0824

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 59e8696 into autowarefoundation:main Jan 29, 2024
29 of 33 checks passed
@soblin soblin deleted the feat/intersection/pass-judge-decision-at-intersection-wo-tl-with-occlusion branch January 29, 2024 13:15
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 29, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Jan 31, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 6, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants