-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(intersection): judge pass judge at intersection without tl with occlusion detection #6207
Merged
soblin
merged 1 commit into
autowarefoundation:main
from
tier4:feat/intersection/pass-judge-decision-at-intersection-wo-tl-with-occlusion
Jan 29, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soblin
requested review from
kyoichi-sugahara,
shmpwk,
takayuki5168 and
tkimura4
as code owners
January 29, 2024 08:05
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jan 29, 2024
takayuki5168
approved these changes
Jan 29, 2024
…cclusion detection Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
feat/intersection/pass-judge-decision-at-intersection-wo-tl-with-occlusion
branch
from
January 29, 2024 08:38
cd7e36c
to
5289b18
Compare
soblin
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 29, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6207 +/- ##
==========================================
- Coverage 14.58% 14.57% -0.01%
==========================================
Files 1878 1878
Lines 128023 128099 +76
Branches 37468 37531 +63
==========================================
Hits 18673 18673
- Misses 88376 88449 +73
- Partials 20974 20977 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
soblin
deleted the
feat/intersection/pass-judge-decision-at-intersection-wo-tl-with-occlusion
branch
January 29, 2024 13:15
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 29, 2024
…cclusion detection (autowarefoundation#6207) Signed-off-by: Mamoru Sobue <[email protected]>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 31, 2024
…cclusion detection (autowarefoundation#6207) Signed-off-by: Mamoru Sobue <[email protected]>
7 tasks
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 6, 2024
…cclusion detection (autowarefoundation#6207) Signed-off-by: Mamoru Sobue <[email protected]>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 6, 2024
feat(intersection): cherry pick intersection (autowarefoundation#6047 + autowarefoundation#6134+ autowarefoundation#6143 + autowarefoundation#6201 + autowarefoundation#6207 + autowarefoundation#6272 + autowarefoundation#6315)
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…cclusion detection (autowarefoundation#6207) Signed-off-by: Mamoru Sobue <[email protected]>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 23, 2024
…cclusion detection (autowarefoundation#6207) Signed-off-by: Mamoru Sobue <[email protected]>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 23, 2024
…cclusion detection (autowarefoundation#6207) Signed-off-by: Mamoru Sobue <[email protected]>
saka1-s
pushed a commit
to saka1-s/autoware.universe
that referenced
this pull request
Nov 9, 2024
…cclusion detection (autowarefoundation#6207) Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basically pass judge passage is judged when "was_safe". And when occlusion detection is enabled, at intersection without traffic light, "OccludedAbsenceTrafficLight" context is treated as safe in terms of occlusion.
Related links
https://tier4.atlassian.net/browse/RT1-4771
Tests performed
intersection occlusion is ON
Before this PR
the pass judge line is still green after passage
After this PR
the pass judge line turns red after passage
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.