chore(radar_crossing_objects_noise_filter): add config file #6210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
scepter914
requested review from
miursh,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
component:perception
Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
kminoda
reviewed
Jan 31, 2024
There was a problem hiding this comment.
LGTM.
Confirmed that
- Autoware launches with this PR (and related PRs).
- Parameters are successfully modified when I modify the .param.yaml file.
See also: TIER IV INTERNAL LINK FOR REWORK PRs
kminoda
added
the
tag:run-build-and-test-differential
miursh
approved these changes
Jan 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6210 +/- ##
==========================================
+ Coverage 14.39% 14.59% +0.19%
==========================================
Files 1906 1878 -28
Lines 129892 127981 -1911
Branches 37615 37454 -161
==========================================
- Hits 18694 18673 -21
+ Misses 90188 88336 -1852
+ Partials 21010 20972 -38
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Feb 1, 2024
…foundation#6210) * chore(radar_crossing_objects_noise_filter): add config file Signed-off-by: scepter914 <[email protected]> * bug fix Signed-off-by: scepter914 <[email protected]> * merge main branch Signed-off-by: scepter914 <[email protected]> --------- Signed-off-by: scepter914 <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…foundation#6210) * chore(radar_crossing_objects_noise_filter): add config file Signed-off-by: scepter914 <[email protected]> * bug fix Signed-off-by: scepter914 <[email protected]> * merge main branch Signed-off-by: scepter914 <[email protected]> --------- Signed-off-by: scepter914 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a config file to
radar_crossing_objects_noise_filterTests performed
Test by rosbag
Effects on system behavior
No
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.