Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(radar_tracks_noise_filter): add config #6211

Conversation

scepter914
Copy link
Contributor

Description

Add a config file to radar_tracks_msgs_converter

Tests performed

Test by rosbag

Effects on system behavior

No

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@scepter914 scepter914 requested a review from kminoda January 29, 2024 10:21
@scepter914 scepter914 requested a review from miursh as a code owner January 29, 2024 10:21
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Jan 29, 2024
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Confirmed that

  • Autoware launches with this PR (and related PRs).
  • Parameters are successfully modified when I modify the .param.yaml file.

See also: TIER IV INTERNAL LINK FOR REWORK PRs

@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25bc636) 14.39% compared to head (a95868c) 14.40%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6211   +/-   ##
=======================================
  Coverage   14.39%   14.40%           
=======================================
  Files        1906     1906           
  Lines      129847   129837   -10     
  Branches    37572    37569    -3     
=======================================
  Hits        18697    18697           
+ Misses      90155    90145   -10     
  Partials    20995    20995           
Flag Coverage Δ *Carryforward flag
differential 41.26% <ø> (?)
total 14.40% <ø> (+<0.01%) ⬆️ Carriedforward from 47f265d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scepter914 scepter914 merged commit d79aa45 into autowarefoundation:main Feb 1, 2024
30 of 34 checks passed
@scepter914 scepter914 deleted the chore/radar_tracks_noise_filter_config branch February 1, 2024 03:49
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Feb 1, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants