fix(map_loader): change error handling when pcd_metadata file not found #6227
Conversation
Signed-off-by: Shintaro Sakoda <[email protected]>
SakodaShintaro
requested review from
anhnv3991,
KYabuuchi,
kminoda,
Motsu-san,
mitsudome-r,
RyuYamamoto and
TaikiYamada4
as code owners
github-actions
bot
added
the
component:map
SakodaShintaro
added
tag:run-build-and-test-differential
|
@SakodaShintaro
It seems fine to me, but do you expect these behaviors? If so, I'd like to approve this. |
|
@TaikiYamada4 kashiwanoha_map is https://github.com/tier4/scenario_simulator_v2/tree/master/map/kashiwanoha_map/map In that case, there was no |
|
@SakodaShintaro |
|
I misunderstood psim. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6227 +/- ##
==========================================
- Coverage 14.40% 14.40% -0.01%
==========================================
Files 1906 1906
Lines 129839 129840 +1
Branches 37571 37572 +1
==========================================
Hits 18697 18697
- Misses 90147 90148 +1
Partials 20995 20995
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SakodaShintaro
merged commit 25bc636
into
autowarefoundation:main
SakodaShintaro
deleted the
fix/change_error_handling_about_pcd_metadata
branch
… not found (autowarefoundation#6227)" This reverts commit 25bc636.
…a file (autowarefoundation#6294) Revert "fix(map_loader): change error handling when pcd_metadata file not found (autowarefoundation#6227)" This reverts commit 25bc636.
…nd (autowarefoundation#6227) Changed error handling when pcd_metadata file not found Signed-off-by: Shintaro Sakoda <[email protected]>
…a file (autowarefoundation#6294) Revert "fix(map_loader): change error handling when pcd_metadata file not found (autowarefoundation#6227)" This reverts commit 25bc636.
Description
When using a divided map,
pointcloud_map_metadata.yamlis required.However, when autoware was run without it, the cause was not displayed in the error message.
This pull request has been modified so that the following error message appears once per second.
Example of error messages that appears on the screen
Note: If you place the
pointcloud_map_metadata.yamlafter the error message appears, themap_loaderstartup sequence itself will probably proceed, but it is unclear whether other Autoware modules will work properly after a long wait. It is safer to restart Autoware.Tests performed
pointcloud_map_metadata.yamlis present (in AWSIM).pointcloud_map_metadata.yamlis missing (in AWSIM).Effects on system behavior
The error message will change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.