Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detection): add container option #6228

Merged
merged 19 commits into from
Feb 1, 2024

Merge branch 'main' into feat/ml_detection/use_container

6b1a5d1
Select commit
Loading
Failed to load commit list.
Merged

feat(detection): add container option #6228

Merge branch 'main' into feat/ml_detection/use_container
6b1a5d1
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 30, 2024 in 49s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method voxel_grid_based_euclidean_cluster.launch.py: launch_setup

Annotations

Check warning on line 99 in perception/euclidean_cluster/launch/voxel_grid_based_euclidean_cluster.launch.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method 

launch_setup has 70 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis