Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mkdocs_macros): ignore when creating a table #6231

Merged

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Jan 30, 2024

Description

I want to add an item to properties in this part of this PR, just for reference. However, when creating a table in a JSON file, it gives the following error.

Screenshot from 2024-01-30 15-40-30

So, if an item contains $ref, I would like to exclude it from the table creation.

Tests performed

browse several pages using mkdocs serve and confirmed that the formatting is not distorted.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 30, 2024
@YamatoAndo YamatoAndo merged commit b415e2e into autowarefoundation:main Jan 31, 2024
30 of 31 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants