-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(avoidance): add function to check if the object is moving #6243
refactor(avoidance): add function to check if the object is moving #6243
Conversation
Signed-off-by: satoshi-ota <[email protected]>
@@ -303,8 +303,7 @@ void AvoidanceModule::fillAvoidanceTargetObjects( | |||
data, parameters_, forward_detection_range + MARGIN, debug); | |||
|
|||
for (const auto & object : object_outside_target_lane.objects) { | |||
ObjectData other_object; | |||
other_object.object = object; | |||
ObjectData other_object = createObjectData(data, object); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use createObjectData
to fill move_time
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6243 +/- ##
==========================================
- Coverage 14.40% 14.40% -0.01%
==========================================
Files 1906 1906
Lines 129843 129844 +1
Branches 37572 37571 -1
==========================================
Hits 18699 18699
- Misses 90150 90151 +1
Partials 20994 20994
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…utowarefoundation#6243) Signed-off-by: satoshi-ota <[email protected]>
…utowarefoundation#6243) Signed-off-by: satoshi-ota <[email protected]>
…utowarefoundation#6243) Signed-off-by: satoshi-ota <[email protected]>
…utowarefoundation#6243) Signed-off-by: satoshi-ota <[email protected]>
…utowarefoundation#6243) Signed-off-by: satoshi-ota <[email protected]>
…utowarefoundation#6243) Signed-off-by: satoshi-ota <[email protected]>
…utowarefoundation#6243) Signed-off-by: satoshi-ota <[email protected]>
…utowarefoundation#6243) Signed-off-by: satoshi-ota <[email protected]>
Description
Add function to check if the object is stopped or not.
Tests performed
Psim
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.