Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radar_crossing_noise_filter): add unit test #6257

Merged

Conversation

N-Eiki
Copy link
Contributor

@N-Eiki N-Eiki commented Jan 31, 2024

Description

add isNoise filter unit test

Related links

Tests performed

test by colcon test

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 31, 2024
Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
@N-Eiki N-Eiki requested a review from technolojin as a code owner February 22, 2024 07:03
@N-Eiki N-Eiki requested a review from scepter914 February 22, 2024 07:12
@scepter914 scepter914 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 26, 2024
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 40.35088% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 14.67%. Comparing base (8e45709) to head (73d0c97).
Report is 5 commits behind head on main.

Files Patch % Lines
...er/test_radar_crossing_objects_filter_is_noise.cpp 40.35% 0 Missing and 34 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6257      +/-   ##
==========================================
+ Coverage   14.64%   14.67%   +0.02%     
==========================================
  Files        1899     1900       +1     
  Lines      130283   130340      +57     
  Branches    38311    38370      +59     
==========================================
+ Hits        19082    19126      +44     
+ Misses      89785    89752      -33     
- Partials    21416    21462      +46     
Flag Coverage Δ *Carryforward flag
differential 42.71% <40.35%> (?)
total 14.64% <ø> (ø) Carriedforward from 8e45709

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scepter914 scepter914 merged commit f95c450 into autowarefoundation:main Feb 26, 2024
31 of 32 checks passed
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…6257)

* update node

Signed-off-by: N-Eiki <[email protected]>

* add test

Signed-off-by: N-Eiki <[email protected]>

* style(pre-commit): autofix

* update year

Signed-off-by: N-Eiki <[email protected]>

* use tier4_autoware_utils

Signed-off-by: N-Eiki <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: N-Eiki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <[email protected]>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
* update node

Signed-off-by: N-Eiki <[email protected]>

* add test

Signed-off-by: N-Eiki <[email protected]>

* style(pre-commit): autofix

* update year

Signed-off-by: N-Eiki <[email protected]>

* use tier4_autoware_utils

Signed-off-by: N-Eiki <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: N-Eiki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…6257)

* update node

Signed-off-by: N-Eiki <[email protected]>

* add test

Signed-off-by: N-Eiki <[email protected]>

* style(pre-commit): autofix

* update year

Signed-off-by: N-Eiki <[email protected]>

* use tier4_autoware_utils

Signed-off-by: N-Eiki <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: N-Eiki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants