Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front_vehicle_velocity): delete package #6258

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Jan 31, 2024

Description

Part of:

This PR delete front_vehicle_velocity_estimator packages because it is currently not used in default Autoware implementation.
This PR need to wait to be merged until 16th of February, related link is https://github.com/orgs/autowarefoundation/discussions/4136.

Related links

https://github.com/orgs/autowarefoundation/discussions/4136

Tests performed

No need

Notes for reviewers

No

Interface changes

No

Effects on system behavior

No

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@scepter914 scepter914 requested a review from kminoda January 31, 2024 14:05
@scepter914 scepter914 requested a review from miursh as a code owner January 31, 2024 14:05
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jan 31, 2024
@scepter914 scepter914 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2024
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit af2bc53 into autowarefoundation:main Feb 8, 2024
16 of 17 checks passed
@scepter914 scepter914 deleted the fix/delete_front_vehicle_velocity_estimator branch February 8, 2024 10:33
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants