Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start_planner): add object_types_to_check_for_path_generation #6370

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Feb 9, 2024

Description

In the original implementation, when generating path, a constant distance margin was attempted to be maintained regardless of the object's class. This approach led to a problem where path could not be generated due to the occurrence of objects of an unknown type, even when there were actually no objects exist.

Ideally, we expect that objects of unknown type will not be detected when no objects exist. However, as a short-term measure, we will enable path generation by ignoring specific classes through parameter adjustment.

Please be cautious when setting this parameter to false, as objects of an unknown class might be recognized, and there could actually be objects present.

In the PR description, I'd like to explain the path generation based on the following settings:

When the configuration is set as:

$ ros2 param get /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner start_planner.object_types_to_check_for_path_generation.check_car
Boolean value is: True

image

Conversely, when the setting is adjusted to:

$ ros2 param get /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner start_planner.object_types_to_check_for_path_generation.check_car
Boolean value is: False

image

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 9, 2024
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/filter_static_object_class branch 6 times, most recently from 5284898 to da5c907 Compare February 21, 2024 16:18
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/filter_static_object_class branch 2 times, most recently from d69c5db to c86491b Compare February 28, 2024 03:32
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Mar 1, 2024
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/filter_static_object_class branch from de83785 to e28a4e8 Compare March 2, 2024 11:40
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/filter_static_object_class branch from e28a4e8 to 2ec4bfb Compare March 2, 2024 11:41
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 2, 2024
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review March 2, 2024 11:42
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (92c478e) to head (2ec4bfb).
Report is 1 commits behind head on main.

Files Patch % Lines
...behavior_path_start_planner_module/src/manager.cpp 0.00% 42 Missing ⚠️
..._start_planner_module/src/start_planner_module.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6370      +/-   ##
==========================================
- Coverage   14.79%   14.78%   -0.01%     
==========================================
  Files        1917     1917              
  Lines      131984   132030      +46     
  Branches    39228    39228              
==========================================
  Hits        19522    19522              
- Misses      90672    90718      +46     
  Partials    21790    21790              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from 92c478e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit ebb4172 into autowarefoundation:main Mar 4, 2024
29 of 32 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/filter_static_object_class branch March 4, 2024 04:17
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Mar 5, 2024
…utowarefoundation#6370)

* add object_types_to_check_for_path_generation

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…6370)

* add object_types_to_check_for_path_generation

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…utowarefoundation#6370)

* add object_types_to_check_for_path_generation

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kaigohirao <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…utowarefoundation#6370)

* add object_types_to_check_for_path_generation

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants