-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(start_planner): add object_types_to_check_for_path_generation #6370
feat(start_planner): add object_types_to_check_for_path_generation #6370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5284898
to
da5c907
Compare
d69c5db
to
c86491b
Compare
de83785
to
e28a4e8
Compare
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
e28a4e8
to
2ec4bfb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6370 +/- ##
==========================================
- Coverage 14.79% 14.78% -0.01%
==========================================
Files 1917 1917
Lines 131984 132030 +46
Branches 39228 39228
==========================================
Hits 19522 19522
- Misses 90672 90718 +46
Partials 21790 21790
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ebb4172
into
autowarefoundation:main
…utowarefoundation#6370) * add object_types_to_check_for_path_generation Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
…6370) * add object_types_to_check_for_path_generation Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
…utowarefoundation#6370) * add object_types_to_check_for_path_generation Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]> Signed-off-by: kaigohirao <[email protected]>
…utowarefoundation#6370) * add object_types_to_check_for_path_generation Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
Description
In the original implementation, when generating path, a constant distance margin was attempted to be maintained regardless of the object's class. This approach led to a problem where path could not be generated due to the occurrence of objects of an unknown type, even when there were actually no objects exist.
Ideally, we expect that objects of unknown type will not be detected when no objects exist. However, as a short-term measure, we will enable path generation by ignoring specific classes through parameter adjustment.
Please be cautious when setting this parameter to false, as objects of an unknown class might be recognized, and there could actually be objects present.
In the PR description, I'd like to explain the path generation based on the following settings:
When the configuration is set as:
Conversely, when the setting is adjusted to:
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.